fix: toast notification not displaying when table is missing

splunk · Aug 6, 2021 · 67b3f12 · 67b3f12
1 parent f23843e
commit 67b3f12
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/ui/src/main/webapp/components/ConfigurationTable.jsx b/ui/src/main/webapp/components/ConfigurationTable.jsx
@@ -1,8 +1,6 @@
 import React, { useState, memo } from 'react';
 import PropTypes from 'prop-types';
 
-import ToastMessages from '@splunk/react-toast-notifications/ToastMessages';
-
 import { TableContextProvider } from '../context/TableContext';
 import TableWrapper from './table/TableWrapper';
 import EntityModal from './EntityModal';
@@ -44,7 +42,6 @@ function ConfigurationTable({ serviceName, serviceTitle }) {
                     serviceName={serviceName}
                     handleRequestModalOpen={() => handleRequestOpen()}
                 />
-                <ToastMessages position="top-right" />
                 {generateModalDialog()}
             </TableContextProvider>
         </>

diff --git a/ui/src/main/webapp/pages/Configuration/ConfigurationPage.jsx b/ui/src/main/webapp/pages/Configuration/ConfigurationPage.jsx
@@ -2,6 +2,7 @@ import React, { useState, useCallback, useEffect } from 'react';
 
 import { _ } from '@splunk/ui-utils/i18n';
 import TabBar from '@splunk/react-ui/TabBar';
+import ToastMessages from '@splunk/react-toast-notifications/ToastMessages';
 import ColumnLayout from '@splunk/react-ui/ColumnLayout';
 import styled from 'styled-components';
 
@@ -101,6 +102,7 @@ function ConfigurationPage() {
                     </div>
                 );
             })}
+            <ToastMessages position="top-right" />
         </ErrorBoundary>
     );
 }