fix(CODE): ADDON-58867 Fixed cancelling selected dropdown value (#188)

Co-authored-by: Tushar Balar <tbalar@splunk.com>
splunk · Dec 8, 2022 · 0144432 · 0144432
1 parent f3e09b1
commit 0144432
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/ui/src/main/webapp/components/BaseFormView.jsx b/ui/src/main/webapp/components/BaseFormView.jsx
@@ -698,7 +698,7 @@ class BaseFormView extends PureComponent {
                     if (required && !currentValue) {
                         load = false;
                         data[dependency] = null;
-                    } else if (currentValue === 'RESET_VALUE') {
+                    } else if (currentValue === 'RESET_DROPDOWN_VALUE') {
                         load = true;
                     } else {
                         data[dependency] = currentValue;
@@ -713,7 +713,10 @@ class BaseFormView extends PureComponent {
                 }
             });
         }
-        changes[field] = { value: { $set: targetValue } };
+
+        // This is the custom logic to handle the dropdown's reset value, and we are setting null value
+        const target_value = targetValue === 'RESET_DROPDOWN_VALUE' ? null : targetValue;
+        changes[field] = { value: { $set: target_value } };
 
         const newFields = update(this.state, { data: changes });
         const tempState = this.clearAllErrorMsg(newFields);
@@ -722,7 +725,7 @@ class BaseFormView extends PureComponent {
         if (this.hookDeferred) {
             this.hookDeferred.then(() => {
                 if (typeof this.hook.onChange === 'function') {
-                    this.hook.onChange(field, targetValue, tempState);
+                    this.hook.onChange(field, target_value, tempState);
                 }
             });
         }

diff --git a/ui/src/main/webapp/components/SingleInputComponent.jsx b/ui/src/main/webapp/components/SingleInputComponent.jsx
@@ -160,7 +160,7 @@ function SingleInputComponent(props) {
                             data-test="clear"
                             appearance="secondary"
                             icon={<Clear />}
-                            onClick={() => restProps.handleChange(field, 'RESET_VALUE')}
+                            onClick={() => restProps.handleChange(field, 'RESET_DROPDOWN_VALUE')}
                         />
                     ) : null}
                 </>