Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach other documents than images to expenses #66

Open
scastiel opened this issue Jan 29, 2024 · 1 comment
Open

Attach other documents than images to expenses #66

scastiel opened this issue Jan 29, 2024 · 1 comment

Comments

@scastiel
Copy link
Member

Since #63 it is possible to attach images to expenses. Might be interested to attach other kind of documents (PDF, doc, video…). Uploading the file is not a problem (you can upload anything to S3), but to see the files, an Image tag is used. We’d need to cover other behavior for other files (with a preview, ability to download…).

@CarliJoy
Copy link

CarliJoy commented Oct 9, 2024

I would say to keep it simple to only show previews for images and no other file types.

For non image attachment one could only show the filename and a download icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants