Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Loops not working properly after sm-json v3.0 implementation in config files. #505

Closed
TandelK opened this issue Apr 24, 2020 · 4 comments

Comments

@TandelK
Copy link
Contributor

TandelK commented Apr 24, 2020

Expected behavior

Normal Veto should show us 7 Maps for veto
Players for match should be as per config file

Actual behavior

Veto are showing 22 Maps for Veto.

Steps to reproduce

get5_debuginfo - https://pastebin.com/dsyiiPvP
Match Config file - https://pastebin.com/PbV5AyTE

  • Plugin version: get5 0.7.2-dev+488
  • Sourcemod version: 1.10.0.6484
  • Steps to reproduce (please be specific):

Use the latest Get5 version with SM 1.10 and run config file given. It was made using example_match.json file . You will be able to see clearly that json loop is not working properly for config. It is creating many duplicates for Maps , Players also.

@TandelK TandelK changed the title [BUG] Loops not working properly after sm-json v3.0 implementation. [BUG] Loops not working properly after sm-json v3.0 implementation in config files. Apr 24, 2020
@TandelK
Copy link
Contributor Author

TandelK commented Apr 25, 2020

@MoritzLoewenstein Please check this issue. I am mentioning you because it broke after you implemented sm-json v3.0 .

@MoritzLoewenstein
Copy link
Contributor

sry, i will look into it.

@TandelK
Copy link
Contributor Author

TandelK commented Apr 30, 2020

@MoritzLoewenstein any updates on them ? It only causes error for Array Structure specially Players Tab and Map List.

@MoritzLoewenstein
Copy link
Contributor

Found the bug, pr coming soon.

@splewis splewis closed this as completed in 478710d May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants