Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support enable speedb feature in CI #723

Closed
ayulas opened this issue Oct 17, 2023 · 8 comments · Fixed by #726
Closed

support enable speedb feature in CI #723

ayulas opened this issue Oct 17, 2023 · 8 comments · Fixed by #726
Assignees
Labels
enhancement New feature or request

Comments

@ayulas
Copy link
Contributor

ayulas commented Oct 17, 2023

support enable speedb feature in CI

@ayulas ayulas self-assigned this Oct 17, 2023
@Yuval-Ariel Yuval-Ariel added the enhancement New feature or request label Oct 17, 2023
@ayulas ayulas assigned hilikspdb and unassigned ayulas Oct 18, 2023
@Guyme
Copy link

Guyme commented Oct 19, 2023

fixes : #726

@Guyme Guyme linked a pull request Oct 19, 2023 that will close this issue
@Guyme
Copy link

Guyme commented Oct 30, 2023

@Guyme will talk to @RoyBenMoshe and see where we take it from there

@ayulas
Copy link
Contributor Author

ayulas commented Oct 30, 2023

@Guyme i talked with @RoyBenMoshe on Friday
What he explained is that the design wasn’t supposed to support recover shared option
To be able support db stress we need some adjustments to it
Any way decide what you want to do

@hilikspdb
Copy link
Contributor

The idea is that the user should call enable_sp.. before any open of the database (new or existing) . all the options that are set are mutable options and the user may change the parameters between runs and use different setting. Rocksdb lacks a config file that is shared between databases and while is see the value i do not think we should tie this project to it.

@Guyme
Copy link

Guyme commented Nov 2, 2023

to my understanding - to close this correctly we need to make sure that dbstress calls on enable_speedb in recovery

@Guyme
Copy link

Guyme commented Nov 7, 2023

@ayulas - #742 is now merged.
Please fix the CI to use enable speedb in recovery as well

@ayulas
Copy link
Contributor Author

ayulas commented Nov 7, 2023

Ok

@ayulas
Copy link
Contributor Author

ayulas commented Nov 9, 2023

@ofriedma pls approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants