-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Licensing: Naming for License properties defined in other standards #210
Comments
@swinslow You make some very good points. We have tried to (re)use previous standards even when the semantics were close, but not exact. In RDF, there is nice feature we can use which is sub-property. For the For To move forward on this issue, I suggest we first decide if we're going to include the full list of properties we defined in the listed license (SPDX spec issue 46 above). I believe it should be included in the spec, but it would require some work to define and document. |
I went back and looked at the proposed class definitions and there already are several properties that help implement the listed license properties mentioned in SPDX Spec issue 46 referenced above. The RDF Terms have a relatively complete list of properties used since I use that for the LicenseListPublisher. We could copy some of those term definitions over to the spec. |
Leaving open to reconsider for 3.0 regarding @goneall's comment above, as to whether there are other properties that haven't been included and ought to be. Also to be discussed whether some of the existing properties (e.g. |
I'll take a pass at comparing the definitions and add properties to match the listed licenses. I'll add them in at the License class unless it is obvious that it only applies to listed licenses. |
Thanks again @goneall for your earlier comments on this. Given that there hasn't been input from others, and that I haven't seen any concerns about the existing property names following -rc2, I'm going to go ahead and close this as "won't fix". If others come back with concerns about this down the road, we can perhaps revisit, but it doesn't sound like there's a need or desire to change things here for 3.0. |
This question follows on from @armintaenzertng's comment at #179 (comment). It relates to the thread at #167 and in particular @goneall's comment at #167 (comment).
The
comment
property for Licenses is, I believe, one of those with semantics defined in other standards, like you described above. See https://www.w3.org/2000/01/rdf-schema#commentAlthough its name is
comment
, if I understand correctly I believe that ties to the "Notes" field for licenses on the SPDX License List. I'm not certain that we are actually using the "Notes" field in a manner that ties into the RDF-defined meaning of "A description of the subject resource." Perhaps this should be changed tolicenseNotes
?A similar situation applies for
seeAlso
, which is described as "Other web pages for this license" on the HTML License List pages and with the<crossRef>
tags in the license list XML syntax. For this one, our usage on the License List does appear to be in line with the RDF-defined meaning of "Further information about the subject resource", but I note the open question about #167 as to overlapping property names across profiles.Finally,
name
for Licenses is perhaps better to change tolicenseName
to avoid similar conflict issues, though I don't think there's the same question about terms defined in other standards.@goneall in particular -- do you have thoughts on this? Should we keep
comment
andseeAlso
with the current names in the SPDX 3.0 model in order to maintain the tie to the RDF terms, or would these be appropriate to change tolicenseNotes
andlicenseCrossRefs
?The text was updated successfully, but these errors were encountered: