Do not use tmp folder

[palypster]

First, awesome package, we use it a lot!

We have found this problem my colleague have reported:
#1720

By quickly scanning the issues, I have found really a lot of issues that are most likely duplicates:
#1777
#1836
#1613
#1389
#1293
#1030
#887
...

Specifically in the latter one, a fix was promised (in 2018):
#887 (comment)

but unfortunately it does not work.

The problem is most likely related to other your package, where there is linked issue. It looks using /tmp folder in general can be very tricky. One guy is proposing what I call an ultimate solution for this very weird problem:
https://github.com/spatie/image/issues/38#issuecomment-381296285

He propose:

a better long term solution would be to avoid using the system /tmp directory to cache conversion files, and instead use a directory within the project

Is this something you consider doing/fixing/changing?

[freekmurze]

This hasn't bitten me yet, that's why I didn't invest time in fixing this.

I'd accept a PR that fixes this on the pro branch of this package, which will be released soon as a new major version.

[palypster]

@freekmurze Thank you. This bothers us a lot. And apparently, it's not that uncommon. We would like to help to solve it.

Can you explain what is the logic behind the removing the tmp directory - this line:
https://github.com/spatie/image/blame/eb0fc87c76af43bbe11382e96ff904084be466be/src/GlideConversion.php#L108

There is even check if the tmp directory is empty. We don't understand why it should be removed in the first place? It's already empty, so no need to remove it we think. If we remove this line, everything works for us. But we don't want to file a PR removing this line, it must had have some purpose I guess :)

[freekmurze]

I honestly don't know anymore. I guess we added it because later in the underlying code it is expected that the directory does not exist.

[palypster]

After analysing both the given and the current state of this file, it's safe to say, there is absolutely no need to remove temp directory.

In the old version, you are never creating the tmp directory. So actually it's probably not even working. The reason why this doesn't bite you is most probably because most of the systems use /tmp as a temp directory and as long as there is hack-like check for ignoring the deletion of /tmp then it's working in 99% case.

In the current version, if someone is changing the temp directory to something else, there is a check if the directory exists and if not, it creates it (so even this shouldn't be a problem).

Clearly it is redundant. Are you willing to review and accept a PR removing that line completely?

[freekmurze]

Sure, send a PR