You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue is a subtask in #235. In short since we plan to add more SQL features we plan to switch to the sqlparser crate which is a feature-rich, no_std-compatible parser used by DataFusion, which is part of the Arrow ecosystem.
Right now we already have some code that can convert intermediate AST from proof-of-sql-parser we use to sqlparser AST. Now we need to systematically replace instances of proof-of-sql-parser constructs with their corresponding sqlparser ones.
Changes Required
Replace proof_of_sql_parser::intermediate_ast::SelectResultExpr with sqlparser::ast::SelectItem in the proof-of-sql crate.
Replace proof_of_sql_parser::intermediate_ast::SetExpression with sqlparser::ast::Select in the proof-of-sql crate.
Replace proof_of_sql_parser::intermediate_ast::SelectStatement with sqlparser::ast::Query in the proof-of-sql crate.
Once this issue is complete there should be no instances of any construct from the proof-of-sql-parser in the proof-of-sql crate.
Note that this issue is blocked until all previous issues related to sqlparser refactoring are complete.
The text was updated successfully, but these errors were encountered:
Background and Motivation
This issue is a subtask in #235. In short since we plan to add more SQL features we plan to switch to the
sqlparser
crate which is a feature-rich,no_std
-compatible parser used by DataFusion, which is part of the Arrow ecosystem.Right now we already have some code that can convert intermediate AST from
proof-of-sql-parser
we use to sqlparser AST. Now we need to systematically replace instances ofproof-of-sql-parser
constructs with their corresponding sqlparser ones.Changes Required
proof_of_sql_parser::intermediate_ast::SelectResultExpr
withsqlparser::ast::SelectItem
in theproof-of-sql
crate.proof_of_sql_parser::intermediate_ast::SetExpression
withsqlparser::ast::Select
in theproof-of-sql
crate.proof_of_sql_parser::intermediate_ast::SelectStatement
withsqlparser::ast::Query
in theproof-of-sql
crate.proof-of-sql-parser
in theproof-of-sql
crate.Note that this issue is blocked until all previous issues related to sqlparser refactoring are complete.
The text was updated successfully, but these errors were encountered: