Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moq is now adware #4255

Closed
ghost opened this issue Aug 11, 2023 · 2 comments
Closed

moq is now adware #4255

ghost opened this issue Aug 11, 2023 · 2 comments

Comments

@ghost
Copy link

ghost commented Aug 11, 2023

see https://github.com/moq/moq/issues/1372 and https://github.com/moq/moq/issues/1374#issuecomment-1671011828

RobustToolbox is currently using Moq v4.16.

Moq after v4.20 adds data collection that (for now only) scrapes git credentials. it will sleep on builds where there is no configured git email connected to a GitHub sponsor.

i am not suggesting using something else; only that at a minimum this dependency not be upgraded ≥4.20. nuget.org packages cannot be trivially overwritten or permanently deleted, so older versions should be safe.

EDIT: it apparently broke Mac builds, so it is temporarily removed in https://github.com/moq/moq/pull/1375

@mirrorcult
Copy link
Contributor

this is why mocking is a mistake

@azzzertyy
Copy link

@ghost ghost closed this as completed Dec 29, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants