Change apt_repository property, because it conflicts with apt resource #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xorima
previously approved these changes
Apr 2, 2019
|
can you get a changelog in @sinfomicien please? |
|
@xorima : i added it under version 2.1.1 in the changelog (as 2.1.0 is already released). |
|
I am not sure we should release this as a patch, it is a breaking change in that the property name has changed, I feel like we should release as 3.0.0 just so people are aware |
xorima
previously approved these changes
Apr 2, 2019
d182ce9 to
0b1fc1b
Compare
0b1fc1b to
2233086
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It correct the repository install for Chef 13
Issues Resolved
Resolve issue [#245]
Check List