Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer phylogenetic options on to sourmash lca gather? #583

Closed
ctb opened this issue Dec 19, 2018 · 4 comments
Closed

Layer phylogenetic options on to sourmash lca gather? #583

ctb opened this issue Dec 19, 2018 · 4 comments

Comments

@ctb
Copy link
Contributor

ctb commented Dec 19, 2018

With the merge of #533, the LCA databases have been updated to be complete and work with regular gather. This means that sourmash lca gather is now kind of redundant. BUT IS IT REALLY?? Well, currently, yes. But the LCA commands explicitly work with taxonomic information that is unavailable to the general public.

We could update lca gather to allow "collapsing" output to a given phylogenetic resolution, e.g. sourmash lca gather -p family .... Right now it defaults to "lowest level available" which means strain or species generally.

@taylorreiter
Copy link
Contributor

+1 collapsing to phylogenetic resolution!

@ctb
Copy link
Contributor Author

ctb commented Apr 29, 2020

relevant #817

@ctb
Copy link
Contributor Author

ctb commented Jun 20, 2020

I wrote a simple script here to do taxonomy things to regular gather output; I think #969 is where we will be taking this since lca gather is itself slated for removal in 4.0.

@ctb
Copy link
Contributor Author

ctb commented Jul 2, 2020

Imma gonna close this b/c the other issues handle this well and sourmash lca gather is going away...

@ctb ctb closed this as completed Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants