Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: find replacement for .sketches()? #2977

Open
bluegenes opened this issue Feb 5, 2024 · 0 comments
Open

core: find replacement for .sketches()? #2977

bluegenes opened this issue Feb 5, 2024 · 0 comments
Labels

Comments

@bluegenes
Copy link
Contributor

bluegenes commented Feb 5, 2024

per @luizirber (paraphrased) -- we should find a replacement for .sketches as it clones all sketch data

https://github.com/sourmash-bio/sourmash/blob/latest/src/core/src/signature.rs#L480-L482

 pub fn sketches(&self) -> Vec<Sketch> {
        self.signatures.clone()
    }

Note: sig.iter() should work for most functions where we might want to use .sketches()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant