Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sourmash multigather to save hash abundances to .unassigned.sig #1707

Closed
ctb opened this issue Aug 8, 2021 · 3 comments · Fixed by #1720
Closed

update sourmash multigather to save hash abundances to .unassigned.sig #1707

ctb opened this issue Aug 8, 2021 · 3 comments · Fixed by #1720
Labels
good second issue Second-tier issues for newer developers!

Comments

@ctb
Copy link
Contributor

ctb commented Aug 8, 2021

In #1620, we factored out the abundance-recovery behavior in sourmash gather for --output-unassigned into a new MinHash.inflate(...) method. This abundance-recovery behavior could now easily be added to multigather, which currently doesn't recover abundances properly.

See CTB: note, multigather does not save abundances in commands.py, near line 980.

To fix:

  • start by writing a test for multigather based on the gather tests for inflation, and make sure that fails on multigather;
  • fix multigather's implementation to pass the test by using the inflate method
@keyabarve
Copy link
Contributor

@ctb Can I work on this issue?

@ctb
Copy link
Contributor Author

ctb commented Aug 15, 2021

sure!

@ctb
Copy link
Contributor Author

ctb commented Sep 23, 2021

being tackled in #1720.

@ctb ctb closed this as completed in #1720 Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good second issue Second-tier issues for newer developers!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants