Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming sourmash_lib module to sourmash #162

Closed
luizirber opened this issue Apr 10, 2017 · 3 comments
Closed

Renaming sourmash_lib module to sourmash #162

luizirber opened this issue Apr 10, 2017 · 3 comments
Assignees

Comments

@luizirber
Copy link
Member

The sourmash_lib name seems to come from the project early days, when the entry point was the sourmash 'executable' in the project root (for dev purposes).

If we use python setup.py develop we don't need the 'executable', and then we can use the name instead of sourmash_lib

@ctb
Copy link
Contributor

ctb commented Apr 11, 2017

-0 on this, at least for the way I work; I like to reference the sourmash script directly while I'm working on pythonland stuff, and having to run 'make' or 'python setup.py develop' seems like an added inconvenience.

@luizirber
Copy link
Member Author

luizirber commented Apr 11, 2017

you already have to run python setup.py build_ext -i for it to work; python setup.py develop just need to be run once (during initial setup), if you are working on pythonland.

@ctb
Copy link
Contributor

ctb commented Nov 11, 2017

I've been thinking about this for a while and (serendipitously) came across this:

https://pip.pypa.io/en/stable/reference/pip_install/#editable-installs

and this:

https://setuptools.readthedocs.io/en/latest/setuptools.html#development-mode

which I didn't really understand before :). I will try it out and see what happens.

Is there a simple way to support both import sourmash_lib and import sourmash for the near future? The select_ksize debacle wrt load_signature was unpleasantly time wasting...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants