-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v*.sbt.json
files in tests/test-data
are built from regular MinHashes, not scaled MinHashes
#1396
Comments
v5 was never in a released version, either. |
incidentally, this problem (the queries and SBTs being regular minhashes) makes it impossible to properly test the old SBTs. So that's the motivation for fixing it! |
6 tasks
note also that |
in #1392 we disabled v1 and v2 tests, FBFW. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This prohibits containment searches (which don't work correctly on regular MinHashes).
In particular, this affects
test_sbt.py::test_tree_old_load(...)
, which usessearch_minhashes_containment
incorrectly.It's not clear what the best option is here -
The text was updated successfully, but these errors were encountered: