Skip to content
This repository has been archived by the owner on Jun 7, 2022. It is now read-only.

Use basic code intel while language server hasn't returned a result #107

Closed
felixfbecker opened this issue Feb 22, 2019 · 2 comments
Closed

Comments

@felixfbecker
Copy link
Contributor

felixfbecker commented Feb 22, 2019

While packages are still installing, we could show the basic-code-intel result if the language server couldn't find one (not just if no server is configured).
For hover and references we can replace the content/list once the real result is in.
For definition, we can always use a small timeout after which code intel is used.

@chrismwendt wdyt?

@chrismwendt
Copy link
Contributor

(continuing from https://github.com/sourcegraph/sourcegraph-typescript/pull/140/files#r270624520)

Complaints were filed against the race() behavior in https://sourcegraph.slack.com/archives/C07KZF47K/p1553879931025500, so I reverted it in sourcegraph/sourcegraph-go#58

I might implement progressive-refinement behavior and put it behind a feature flag to gather feedback sourcegraph/sourcegraph-go#57 (comment), but it might be met with complaints similar to the race() behavior. I'm curious if you're optimistic about it.

@chrismwendt
Copy link
Contributor

Closing because:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants