From 067ac320470b675a94218e14108f01f932c2f7bb Mon Sep 17 00:00:00 2001 From: Robert Lin Date: Mon, 28 Sep 2020 22:29:50 +0800 Subject: [PATCH 1/3] releases: remove manual changelog check, add changelog workflow --- handbook/engineering/releases/release_issue_template.md | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/handbook/engineering/releases/release_issue_template.md b/handbook/engineering/releases/release_issue_template.md index 3e397b60897..8965b2f26d7 100644 --- a/handbook/engineering/releases/release_issue_template.md +++ b/handbook/engineering/releases/release_issue_template.md @@ -32,13 +32,7 @@ Arguments: ## $FOUR_WORKING_DAYS_BEFORE_RELEASE (4 work days before release): Branch cut -- [ ] Verify for each CHANGELOG item the following (if any item does not have these, disable it, - notify the owner, and remove it from the CHANGELOG): - - It has an owner attached to it - - It has undergone manual QA (and the QA was done on k8s.sgdev.org or at scale if the feature requires it). - - It is covered by the regression test suite -- [ ] Add a new section `## $MAJOR.MINOR` to [CHANGELOG.md](https://github.com/sourcegraph/sourcegraph/blob/main/CHANGELOG.md#unreleased) immediately under `## Unreleased changes`. Add new empty sections under `## Unreleased changes` ([example](https://github.com/sourcegraph/sourcegraph/pull/2323)). -- [ ] Commit this CHANGELOG edit to `main` using a PR. +- [ ] Run the ["Release(changelog)" workflow](TODO) to generate a pull request updating the changelog and merge it. - [ ] Create the `$MAJOR.$MINOR` branch off the CHANGELOG commit in the previous step: `git branch $MAJOR.$MINOR && git push origin $MAJOR.$MINOR`. - [ ] Tag and announce the first release candidate: ``` From 3eeecd3c805c036bb1fbce01223710beb7048e94 Mon Sep 17 00:00:00 2001 From: Robert Lin Date: Tue, 29 Sep 2020 14:44:47 +0800 Subject: [PATCH 2/3] add temp link --- handbook/engineering/releases/release_issue_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/handbook/engineering/releases/release_issue_template.md b/handbook/engineering/releases/release_issue_template.md index 8965b2f26d7..acad1adc91a 100644 --- a/handbook/engineering/releases/release_issue_template.md +++ b/handbook/engineering/releases/release_issue_template.md @@ -32,7 +32,7 @@ Arguments: ## $FOUR_WORKING_DAYS_BEFORE_RELEASE (4 work days before release): Branch cut -- [ ] Run the ["Release(changelog)" workflow](TODO) to generate a pull request updating the changelog and merge it. +- [ ] Run the ["Release(changelog)" workflow](https://github.com/sourcegraph/sourcegraph/actions?query=workflow%3ARelease%28changelog%29+) to generate a pull request updating the changelog and merge it. - [ ] Create the `$MAJOR.$MINOR` branch off the CHANGELOG commit in the previous step: `git branch $MAJOR.$MINOR && git push origin $MAJOR.$MINOR`. - [ ] Tag and announce the first release candidate: ``` From 8e9da49c5c54b1d09ce375c2292e2f4c52196f19 Mon Sep 17 00:00:00 2001 From: Robert Lin Date: Tue, 29 Sep 2020 20:26:55 +0800 Subject: [PATCH 3/3] remove workflow reference, just use the release tool --- handbook/engineering/releases/release_issue_template.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/handbook/engineering/releases/release_issue_template.md b/handbook/engineering/releases/release_issue_template.md index acad1adc91a..59beb1bf56f 100644 --- a/handbook/engineering/releases/release_issue_template.md +++ b/handbook/engineering/releases/release_issue_template.md @@ -32,7 +32,10 @@ Arguments: ## $FOUR_WORKING_DAYS_BEFORE_RELEASE (4 work days before release): Branch cut -- [ ] Run the ["Release(changelog)" workflow](https://github.com/sourcegraph/sourcegraph/actions?query=workflow%3ARelease%28changelog%29+) to generate a pull request updating the changelog and merge it. +- [ ] Update the changelog and merge the generated pull request: + ``` + yarn run release changelog:cut $MAJOR.$MINOR.0 + ``` - [ ] Create the `$MAJOR.$MINOR` branch off the CHANGELOG commit in the previous step: `git branch $MAJOR.$MINOR && git push origin $MAJOR.$MINOR`. - [ ] Tag and announce the first release candidate: ```