Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use x86-interrupt calling convention rather than naked fns #78

Closed
hawkw opened this issue Feb 28, 2017 · 1 comment
Closed

Use x86-interrupt calling convention rather than naked fns #78

hawkw opened this issue Feb 28, 2017 · 1 comment
Assignees
@hawkw
Labels
arch/x86_all Architecture: this issue is specific to all x86 architectures area/kernel Area: this issue relates to the core kernel. kind/refactor Kind: this issue describes refactoring or code quality improvement.

Comments

@hawkw
Copy link
Member

hawkw commented Feb 28, 2017

When rust-lang/rust#39832 is merged to nightly, I can rewrite my interrupt-handling code for x86 to use the x86-interrupt calling convention, which will be much less ugly than the current implementation and might also lead to improved performance.

This may also allow some interrupt handlers to be written more generally, for both 32-bit and 64-bit x86?
@hawkw hawkw added area/kernel Area: this issue relates to the core kernel. kind/refactor Kind: this issue describes refactoring or code quality improvement. arch/x86_all Architecture: this issue is specific to all x86 architectures labels Feb 28, 2017
@hawkw hawkw self-assigned this Feb 28, 2017
@hawkw
Copy link
Member Author

hawkw commented Mar 4, 2017

x86-interrupt ABI should be on nightly rust now, so this can be started...

@hawkw hawkw mentioned this issue May 23, 2017
Merged
@hawkw hawkw closed this as completed in #98 May 23, 2017
@hawkw hawkw mentioned this issue May 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hawkw hawkw

Labels
arch/x86_all Architecture: this issue is specific to all x86 architectures area/kernel Area: this issue relates to the core kernel. kind/refactor Kind: this issue describes refactoring or code quality improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hawkw