-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit and Rollback should be optional #27
Comments
I personally agree with this. The change is simple and it will not break the library. @sorodrigo @wacii Any thoughts? |
Yeah, I'm fine with this. Not sure that I can think of a situation where I wouldn't want to be notified of a failure, but there is no reason for the library to impose that. |
I'm not sure about the use case. If you don't want to be notified about a failure, why not use an effect outside of |
I have an use case right now where an action updates the local database and then syncs with the backend. These actions will be retried until they succeed and no conflict resolution has to be done on them, so they eventually will. Doing these actions outside of |
#30 Solves this. |
Pretty much following up on this issue redux-offline#72 in this repo since it is actively maintained.
What do you think? That seeems like a reasonable idea, as you don't necessarily want to dispatch a commit/rollback action for every offline action, for example in the case of an optimistic update (as shown in examples in the README).
The text was updated successfully, but these errors were encountered: