diff --git a/platform/broadcom/sonic-platform-modules-dell/s5212f/scripts/platform_sensors.py b/platform/broadcom/sonic-platform-modules-dell/s5212f/scripts/platform_sensors.py index 327d03bc7b8d..0fc484be2f07 100755 --- a/platform/broadcom/sonic-platform-modules-dell/s5212f/scripts/platform_sensors.py +++ b/platform/broadcom/sonic-platform-modules-dell/s5212f/scripts/platform_sensors.py @@ -11,7 +11,6 @@ # * PSU -import os import sys import logging import commands @@ -79,7 +78,7 @@ def get_switch_details(): if (partno in switch_sku): return switch_sku[partno] return None -ret_status, ipmi_cmd_ret = commands.getstatusoutput('echo 0 > /sys/module/ipmi_si/parameters/kipmid_max_busy_us') +commands.getstatusoutput('echo 0 > /sys/module/ipmi_si/parameters/kipmid_max_busy_us') print_temperature_sensors() # Print the information for 1 Fan Tray diff --git a/platform/broadcom/sonic-platform-modules-dell/s5212f/scripts/qsfp_irq_enable.py b/platform/broadcom/sonic-platform-modules-dell/s5212f/scripts/qsfp_irq_enable.py index 5050475f987e..faf74040cf64 100755 --- a/platform/broadcom/sonic-platform-modules-dell/s5212f/scripts/qsfp_irq_enable.py +++ b/platform/broadcom/sonic-platform-modules-dell/s5212f/scripts/qsfp_irq_enable.py @@ -2,7 +2,6 @@ try: import struct - import sys from os import * from mmap import * diff --git a/platform/broadcom/sonic-platform-modules-dell/s5212f/scripts/s5212f_platform.sh b/platform/broadcom/sonic-platform-modules-dell/s5212f/scripts/s5212f_platform.sh index 2a5caf90ed70..2c778cf98b43 100755 --- a/platform/broadcom/sonic-platform-modules-dell/s5212f/scripts/s5212f_platform.sh +++ b/platform/broadcom/sonic-platform-modules-dell/s5212f/scripts/s5212f_platform.sh @@ -150,7 +150,7 @@ install_python_api_package() { } remove_python_api_package() { - rv=$(pip show sonic-platform > /dev/null 2>/dev/null) + rv=$(pip3 show sonic-platform > /dev/null 2>/dev/null) if [ $? -eq 0 ]; then rv=$(pip3 uninstall -y sonic-platform > /dev/null 2>/dev/null) fi diff --git a/platform/broadcom/sonic-platform-modules-dell/s5212f/sonic_platform/chassis.py b/platform/broadcom/sonic-platform-modules-dell/s5212f/sonic_platform/chassis.py index e308fb977f8c..64f926f64c1f 100644 --- a/platform/broadcom/sonic-platform-modules-dell/s5212f/sonic_platform/chassis.py +++ b/platform/broadcom/sonic-platform-modules-dell/s5212f/sonic_platform/chassis.py @@ -11,9 +11,7 @@ try: import os import time - import select import sys - import binascii from sonic_platform_base.chassis_base import ChassisBase from sonic_platform.sfp import Sfp from sonic_platform.eeprom import Eeprom @@ -132,7 +130,7 @@ def _get_register(self, reg_file): try: with os.fdopen(os.open(reg_file, os.O_RDONLY)) as fd: retval = fd.read() - except: + except Exception: pass retval = retval.rstrip('\r\n') retval = retval.lstrip(" ") @@ -300,7 +298,7 @@ def get_reboot_cause(self): try: with open(self.REBOOT_CAUSE_PATH) as fd: reboot_cause = int(fd.read(), 16) - except: + except Exception: return (self.REBOOT_CAUSE_NON_HARDWARE, None) if reboot_cause & 0x1: diff --git a/platform/broadcom/sonic-platform-modules-dell/s5212f/sonic_platform/component.py b/platform/broadcom/sonic-platform-modules-dell/s5212f/sonic_platform/component.py index 73a47f868d8e..a1bba0c9d372 100644 --- a/platform/broadcom/sonic-platform-modules-dell/s5212f/sonic_platform/component.py +++ b/platform/broadcom/sonic-platform-modules-dell/s5212f/sonic_platform/component.py @@ -10,8 +10,6 @@ ######################################################################## try: - import os - import re import subprocess from sonic_platform_base.component_base import ComponentBase import sonic_platform.hwaccess as hwaccess @@ -59,8 +57,7 @@ class Component(ComponentBase): ], ['BMC', - 'Platform management controller for on-board temperature ' - 'monitoring, in-chassis power, Fan and LED control', + 'Platform management controller for on-board temperature monitoring, in-chassis power, Fan and LED control', get_bmc_version ], diff --git a/platform/broadcom/sonic-platform-modules-dell/s5212f/sonic_platform/watchdog.py b/platform/broadcom/sonic-platform-modules-dell/s5212f/sonic_platform/watchdog.py index 16eeee7ab5e4..fd3ace892387 100644 --- a/platform/broadcom/sonic-platform-modules-dell/s5212f/sonic_platform/watchdog.py +++ b/platform/broadcom/sonic-platform-modules-dell/s5212f/sonic_platform/watchdog.py @@ -10,8 +10,6 @@ ######################################################################## try: - import sys - import struct import ctypes import subprocess import syslog @@ -141,8 +139,6 @@ def arm(self, seconds): self.timeout = seconds return seconds - return -1 - def disarm(self): """ Disarm the hardware watchdog