Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with virtual property not being pulled through #4

Closed
Hefaistos68 opened this issue Aug 24, 2020 · 8 comments · Fixed by #11
Closed

Problem with virtual property not being pulled through #4

Hefaistos68 opened this issue Aug 24, 2020 · 8 comments · Fixed by #11

Comments

@Hefaistos68
Copy link

The comments of virtual properties are not available to pull through.

@someguy20336
Copy link
Owner

Virtual properties are supported, but only if the base class is located in your solution. I suspect you are trying to pull through something like "Object.ToString()" where the base class is not located in your solution.

I do not currently support pulling that through because Roslyn does not have that documentation in the model. I would need to manually look up the xml, which I haven't gotten to yet.

I will keep this open as a good enhancement if I ever get to it.

@someguy20336 someguy20336 added the enhancement New feature or request label Aug 29, 2020
@someguy20336 someguy20336 changed the title virtual properties are not available Support pulling through documentation outside of solution Aug 29, 2020
@Hefaistos68
Copy link
Author

Actually I an seeing that on classes in the same project with properties from base classes in the solution.

@someguy20336 someguy20336 removed the enhancement New feature or request label Aug 29, 2020
@someguy20336 someguy20336 changed the title Support pulling through documentation outside of solution Problem with virtual property not being pulled through Aug 29, 2020
@someguy20336
Copy link
Owner

Interesting... Can you give a little more details? I definitely have a passing unit test for this exact scenario, so there must be something else at play here:

https://github.com/someguy20336/PullThroughDoc/blob/master/PullThroughDoc/PullThroughDoc.Test/PullThroughDocUnitTests.cs#L200

@someguy20336
Copy link
Owner

ooooooooooh wait - PROPERTIES and not methods? I think i misread this whole thing... let me look into that...

@someguy20336
Copy link
Owner

Ok, I think I still need more information about your setup. Properties seem to work just fine for me (i tried both public and protected). In your project, how are the classes related to each other in the project structure?

Maybe some sample code would help too.

@Hefaistos68
Copy link
Author

Will check whats the relation of the classes here. But its all in the same project (C# 8, .Net Core), give me a day to find out, its not happening with all properties in just any class.

@someguy20336
Copy link
Owner

Did you ever get a chance to look at this? Could this just be the same issue we just made #9 ?

@Hefaistos68
Copy link
Author

I am testing here with a larger project I am working on, i remember that this was not a constant problem but rather limited to some classes. Since this project uses practically none of the .NET classes to derive of, I think its not related to the other issue.
So far I could not repro it, maybe either the last version fixed it, or i didnt test the right situation. Keep you posted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants