Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss the use of miniconda for installing dependencies #4

Closed
j8xixo12 opened this issue Jan 22, 2021 · 8 comments
Closed

Discuss the use of miniconda for installing dependencies #4

j8xixo12 opened this issue Jan 22, 2021 · 8 comments
Assignees
Labels
discuss Need more discussion

Comments

@j8xixo12
Copy link
Collaborator

This script uses miniconda for most of the dependencies so I think it's probably good to highlight it in the filename. We may do it with this PR or act after more discussions.

Originally posted by @yungyuc in #1 (comment)

@j8xixo12 j8xixo12 added the enhancement New feature or request label Jan 22, 2021
@j8xixo12 j8xixo12 added discuss Need more discussion and removed enhancement New feature or request labels Jan 22, 2021
@tai271828
Copy link
Collaborator

Thanks for filing issues from the comment of #1 so fast. It is so fast that I thought it was done by some github feature. : )

@yungyuc
Copy link
Member

yungyuc commented Jan 22, 2021

Impressive. Thanks a lot, @j8xixo12 .

@yungyuc yungyuc changed the title This script uses miniconda for most of the dependencies so I think it's probably good to highlight it in the filename. We may do it with this PR or act after more discussions. Discuss the use of miniconda for installing dependencies Jan 22, 2021
@tai271828
Copy link
Collaborator

In my opinion, the most straightforward implementation is to build each package of conda from source one by one. At the very beginning we use conda. In the end we may build as many packages from source on our own as possible.

@yungyuc
Copy link
Member

yungyuc commented Jan 28, 2021

In my opinion, the most straightforward implementation is to build each package of conda from source one by one. At the very beginning we use conda. In the end we may build as many packages from source on our own as possible.

That sounds like duplicating what conda forge does.

Besides, it doesn't sound like to allow multiple DEs (rel, dbg, etc.) in parallel?

@tai271828
Copy link
Collaborator

tai271828 commented Apr 15, 2021

The discussion of #13 (comment) make me recall this thread. Sorry for the late reply.

In my opinion, the most straightforward implementation is to build each package of conda from source one by one. At the very beginning we use conda. In the end we may build as many packages from source on our own as possible.

That sounds like duplicating what conda forge does.

I am not sure if we are on the same page. For me, it is devenv management tool to add/replace each packages. If devenv management tool could build all packages we need to launch devenv-cli.sh in CI, we could abandon the use of miniconda anytime.

Besides, it doesn't sound like to allow multiple DEs (rel, dbg, etc.) in parallel?

I did not follow the last question. What did you mean by "not allow multiple DEs (rel, dbg, etc.) in parallel? Why?

@yungyuc
Copy link
Member

yungyuc commented Apr 16, 2021

The discussion of #13 (comment) make me recall this thread. Sorry for the late reply.

In my opinion, the most straightforward implementation is to build each package of conda from source one by one. At the very beginning we use conda. In the end we may build as many packages from source on our own as possible.

That sounds like duplicating what conda forge does.

I am not sure if we are on the same page. For me, it is devenv management tool to add/replace each packages. If devenv management tool could build all packages we need to launch devenv-cli.sh in CI, we could abandon the use of miniconda anytime.

Agree that when devenv builds everything we don't need conda anymore. Conda may be left as an optional step for packages we prefer to not build, though.

Besides, it doesn't sound like to allow multiple DEs (rel, dbg, etc.) in parallel?

I did not follow the last question. What did you mean by "not allow multiple DEs (rel, dbg, etc.) in parallel? Why?

I meant, the conda builder doesn't seem to allow building different flavors (rel/dbg). But I am not sure. Does it?

@tai271828
Copy link
Collaborator

tai271828 commented Apr 16, 2021

The discussion of #13 (comment) make me recall this thread. Sorry for the late reply.

In my opinion, the most straightforward implementation is to build each package of conda from source one by one. At the very beginning we use conda. In the end we may build as many packages from source on our own as possible.

That sounds like duplicating what conda forge does.

I am not sure if we are on the same page. For me, it is devenv management tool to add/replace each packages. If devenv management tool could build all packages we need to launch devenv-cli.sh in CI, we could abandon the use of miniconda anytime.

Agree that when devenv builds everything we don't need conda anymore. Conda may be left as an optional step for packages we prefer to not build, though.

Cool! We are on the same page : D

Besides, it doesn't sound like to allow multiple DEs (rel, dbg, etc.) in parallel?

I did not follow the last question. What did you mean by "not allow multiple DEs (rel, dbg, etc.) in parallel? Why?

I meant, the conda builder doesn't seem to allow building different flavors (rel/dbg). But I am not sure. Does it?

I see. I am not sure too. My gut feeling is "no, it doesn't".

@yungyuc
Copy link
Member

yungyuc commented Apr 16, 2021

I realize that this page here is an issue but we actually have repository discussions set up. Let's move the discussions there: #14 .

@yungyuc yungyuc closed this as completed Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Need more discussion
Projects
None yet
Development

No branches or pull requests

3 participants