Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

lending: Add slippage constraint for borrow instruction #988

Closed
jstarry opened this issue Dec 31, 2020 · 2 comments · Fixed by #3423
Closed

lending: Add slippage constraint for borrow instruction #988

jstarry opened this issue Dec 31, 2020 · 2 comments · Fixed by #3423
Milestone

Comments

@jstarry
Copy link
Contributor

jstarry commented Dec 31, 2020

Problem

When processing a borrow instruction which is denoted by deposited collateral, there is currently no way to specify the minimum number of borrowed tokens to receive.

Processing borrows denoted by requested borrow tokens does not need an explicit slippage constraint because collateral tokens can be restricted by using SPL token's delegate instruction. But it seems nice to have a slippage constraint for this direction too.

Proposed Changes

Add minimum amount to borrow instruction params

@jmalcic
Copy link
Contributor

jmalcic commented Jul 20, 2022

@joncinque would it be useful for me to work on this?

@joncinque
Copy link
Contributor

@jmalcic certainly, this should be a fun one -- go for it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants