-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renderButtonText does not work #127
Comments
@Mexxerio Check your package.json. And change "react-native-modal-dropdown": "^0.5.0" to "^0.6.0". |
@IvanIvaschenko It already is on |
@Mexxerio find the module in node_modules. Open ModalDropdown and look on line 361 you should see this string buttonText: renderButtonText && renderButtonText(rowData) || rowData.toString(). If no try to restart packager. |
@IvanIvaschenko It's there. |
@Mexxerio share your code. |
is this library work both ios and android , i am still getting [object object ] |
I am also getting this issue as well. Here is a snippet of my code I continue to get [object object] and i double checked that im on version ^0.6.0.
Dug around a bit more if i remove the onSelect from ModalDropdown the renderButtonText works. |
@atul-forbinary @mrkirchner You can use dirty hack. <ModalDropdown onSelect = async (value, indx) => { |
@IvanIvaschenko Not sure what your trying to show here. Anytime i try to setState or call a props.function in my selectHandler it will not work. @sohobloo Any suggestions on whats going on or is it a bug? Doing a quick look at your js it seems like renderButtonText is only being used onPress does it also need to happen on select(idx) or componentWillReceiveProps? Issue only occurs on a a onSelect Function which contains a setState in it. I assume its because setState is asynchronous but not sure of a way around that. |
Opened an MR #131 not sure if that is best way to fix things. Still learning react ... |
This issue has been fixed. Please update to v0.6.1 Sorry, my fault and thanks to @swb2016(#128) |
I am also still finding this issue, I have version 0.6.1 |
@sohobloo same here, 0.6.1 version and still hitting the [object] thing, why is this so tough to get working? |
The newly added
renderButtonText
property does not work. The function gets called after an option is selected, but it doesn't correctly set the button text. It still shows[object Object]
.The text was updated successfully, but these errors were encountered: