From 81e46928855f031426bdc6e26350e516d61ac5cc Mon Sep 17 00:00:00 2001 From: Pieter De Baets Date: Tue, 19 Nov 2024 09:02:49 +0000 Subject: [PATCH] feat: update SvgPackage to supported stable API's (#2541) Address some deprecated API's in SVGPackage # Summary This improves compatibility with future React Native releases, which will remove TurboReactPackage and the ReactModuleInfo constructor used. ## Test Plan CI --- android/src/main/java/com/horcrux/svg/SvgPackage.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/android/src/main/java/com/horcrux/svg/SvgPackage.java b/android/src/main/java/com/horcrux/svg/SvgPackage.java index bc116e13d..fe81f02c3 100644 --- a/android/src/main/java/com/horcrux/svg/SvgPackage.java +++ b/android/src/main/java/com/horcrux/svg/SvgPackage.java @@ -11,7 +11,7 @@ import static com.horcrux.svg.RenderableViewManager.*; import androidx.annotation.Nullable; -import com.facebook.react.TurboReactPackage; +import com.facebook.react.BaseReactPackage; import com.facebook.react.ViewManagerOnDemandReactPackage; import com.facebook.react.bridge.JavaScriptModule; import com.facebook.react.bridge.ModuleSpec; @@ -36,7 +36,7 @@ SvgViewModule.class, RNSVGRenderableManager.class, }) -public class SvgPackage extends TurboReactPackage implements ViewManagerOnDemandReactPackage { +public class SvgPackage extends BaseReactPackage implements ViewManagerOnDemandReactPackage { private @Nullable Map mViewManagers; @@ -369,7 +369,6 @@ public Map getReactModuleInfos() { moduleClass.getName(), reactModule.canOverrideExistingModule(), reactModule.needsEagerInit(), - reactModule.hasConstants(), reactModule.isCxxModule(), true)); }