Inefficient Usage of JCF

[FastAtlas]

Hi,

We find that there are several ArrayList objects which are not manipulated by random access. Due to the memory reallocation triggered in the successive insertions, the time complexity of add method of ArrayList is amortized O(1). We notice that these objects are only used for traversal, the retrieval, and removal of the first or the last element.

This functionality can be implemented by LinkedList. Moreover, the insertion of LinkedList is strictly O(1) time complexity because no memory reallocation occurs.

Meanwhile, we also found several LinkedHashSet and LinkedHashMap objects which are not necessary to maintain the order of insertions. To achieve the same functionality, HashHap and HashSet are enough. The replacement can also reduce the time cost in the modification of the map objects.

We discovered the above inefficient usage of containers by our tool Ditto. The patch is submitted in #1079. Could you please check and accept it? We have tested the patch on our PC. The patched program works well.

Bests

Ditto

[OrezzerO]

Thank you for your PR, we will check the changes later.Performance is important for us, your work can help us a lot