From 19cc6e5622926d4e9eb6b352cf532c3680b49ff0 Mon Sep 17 00:00:00 2001 From: cyphersnake Date: Mon, 28 Oct 2024 14:59:49 +0100 Subject: [PATCH] fix(nifs): bits count for protogalaxy challenges --- src/nifs/protogalaxy/mod.rs | 6 +++--- src/nifs/protogalaxy/tests.rs | 5 +---- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/src/nifs/protogalaxy/mod.rs b/src/nifs/protogalaxy/mod.rs index 909403a6..72424720 100644 --- a/src/nifs/protogalaxy/mod.rs +++ b/src/nifs/protogalaxy/mod.rs @@ -6,7 +6,7 @@ use tracing::{debug, instrument, warn}; use super::*; use crate::{ commitment::CommitmentKey, - constants::{MAX_BITS, NUM_CHALLENGE_BITS}, + constants::MAX_BITS, ff::PrimeField, halo2_proofs::arithmetic::{self, CurveAffine, Field}, nifs::protogalaxy::poly::PolyContext, @@ -358,7 +358,7 @@ impl FoldingScheme for ProtoGalaxy { let alpha = ro_acc .absorb_field_iter(poly_F.iter().map(|v| C::scalar_to_base(v).unwrap())) - .squeeze::(NUM_CHALLENGE_BITS); + .squeeze::(MAX_BITS); let betas_stroke = poly::PolyChallenges { betas: accumulator.betas.clone(), @@ -378,7 +378,7 @@ impl FoldingScheme for ProtoGalaxy { let gamma = ro_acc .absorb_field_iter(poly_K.iter().map(|v| C::scalar_to_base(v).unwrap())) - .squeeze::(NUM_CHALLENGE_BITS); + .squeeze::(MAX_BITS); debug!( " diff --git a/src/nifs/protogalaxy/tests.rs b/src/nifs/protogalaxy/tests.rs index 0de12ed2..883b0ec6 100644 --- a/src/nifs/protogalaxy/tests.rs +++ b/src/nifs/protogalaxy/tests.rs @@ -167,10 +167,7 @@ impl> Mock { let accumulator_inst_from_prove = AccumulatorInstance::from(accumulator_from_prove); - assert_eq!( - accumulator_inst_from_prove, - accumulator_from_verify, - ); + assert_eq!(accumulator_inst_from_prove, accumulator_from_verify,); } }