Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Improve streaming Blob testing suite #2115

Closed
crisidev opened this issue Dec 20, 2022 · 1 comment
Closed

[Python] Improve streaming Blob testing suite #2115

crisidev opened this issue Dec 20, 2022 · 1 comment
Labels
python-server Python server SDK

Comments

@crisidev
Copy link
Contributor

The Blob tests are far from ideal. They do not work with asyncio is involved and it seems like during tests the Blob is loaded in memory and not really streamed, while when running on a real application the streaming feature seems to be working properly.

https://github.com/awslabs/smithy-rs/blob/main/rust-runtime/aws-smithy-http-server-python/src/types.rs#L499

@crisidev crisidev added the python-server Python server SDK label Dec 20, 2022
@unexge
Copy link
Contributor

unexge commented Mar 7, 2023

I believe this is addressed with #2431. I didn't pay attention to the issue about loading the whole content to the memory, but it seems like the test is problematic (I think we should use stream::repeat instead of String::repeat). I'll close this ticket, but we can revisit that problem as part of #1752

@unexge unexge closed this as completed Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python-server Python server SDK
Projects
None yet
Development

No branches or pull requests

2 participants