Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dilepton target fails due to Unstable Particle and HAFT issues #86

Closed
NGoetz opened this issue Dec 21, 2024 · 13 comments
Closed

Dilepton target fails due to Unstable Particle and HAFT issues #86

NGoetz opened this issue Dec 21, 2024 · 13 comments
Assignees

Comments

@NGoetz
Copy link
Member

NGoetz commented Dec 21, 2024

During the rc analysis run, the following issues occured:

[  0%] Running SMASH for dileptons/ArKCl_1.76_filtered at 1.76 GeV (1/100).
[  0%] Running f2py.
[16'27'58]  WARN      DecayModes     : Branching ratios of 51 hadrons were renormalized by more than 1% to have sum 1.
[16'27'58] FATAL         Main        : SMASH failed with the following error:
                                       Unstable particle D*(2007)⁺ has no decay chanels! Either add one to it in decaymodes file or set it's width to 0 in particles file.
make[3]: *** [test/dileptons/CMakeFiles/dileptons_ArKCl_1.76_filtered_analysis.dir/build.make:1796: test/dileptons/ArKCl_1.76_filtered/data/1/Dileptons.bin] Error 1
make[2]: *** [CMakeFiles/Makefile2:5814: test/dileptons/CMakeFiles/dileptons_ArKCl_1.76_filtered_analysis.dir/all] Error 2
make[2]: *** Waiting for unfinished jobs....
[  0%] Running SMASH for dileptons/pp_1.25_filtered at 1.25 GeV (1/100).
running build
running config_cc
unifing config_cc, config, build_clib, build_ext, build commands --compiler options
running config_fc
unifing config_fc, config, build_clib, build_ext, build commands --fcompiler options
running build_src
build_src
building extension "HAFT" sources
f2py options: ['skip:', 'momspread', 'readhaftmatrix', 'getmatrixval', 'gettableval', 'param', 'smearhades4momentum', 'readhaftpairmatrix', ':']
f2py:> /tmp/tmp5vplxus_/src.linux-x86_64-3.10/HAFTmodule.c
creating /tmp/tmp5vplxus_/src.linux-x86_64-3.10
[16'27'58]  WARN      DecayModes     : Branching ratios of 51 hadrons were renormalized by more than 1% to have sum 1.
[16'27'58] FATAL         Main        : SMASH failed with the following error:
                                       Unstable particle D*(2007)⁺ has no decay chanels! Either add one to it in decaymodes file or set it's width to 0 in particles file.
make[3]: *** [test/dileptons/CMakeFiles/dileptons_pp_1.25_filtered_analysis.dir/build.make:1191: test/dileptons/pp_1.25_filtered/data/1/Dileptons.bin] Error 1
make[3]: *** Waiting for unfinished jobs....
Reading fortran codes...
	Reading file '/lustre/hyihp/ngoetz/smash-analysis-extras/experimental_data/HADES_dilepton_filtering/readHAFT2.f90' (format:free)
Line #372 in /lustre/hyihp/ngoetz/smash-analysis-extras/experimental_data/HADES_dilepton_filtering/readHAFT2.f90:"  type :: AcceptanceMatrix "
	analyzeline: No name/args pattern found for line.
Line #383 in /lustre/hyihp/ngoetz/smash-analysis-extras/experimental_data/HADES_dilepton_filtering/readHAFT2.f90:"  type :: ResParameterTable "
	analyzeline: No name/args pattern found for line.
Post-processing...
	Block: HAFT
			Block: haft_aux
In: :HAFT:/lustre/hyihp/ngoetz/smash-analysis-extras/experimental_data/HADES_dilepton_filtering/readHAFT2.f90:haft_aux
get_parameters: got "name 'log' is not defined" on 'log(10.)'
				Block: kernel
				Block: samplegauss
				Block: samplemp
				Block: interpol
			Block: haft_single
				Block: unknown_type
				Block: unknown_type
				Block: setfilename
				Block: gethadesacceptance
In: :HAFT:/lustre/hyihp/ngoetz/smash-analysis-extras/experimental_data/HADES_dilepton_filtering/readHAFT2.f90:haft_single:gethadesacceptance
get_parameters: got "name 'log' is not defined" on 'log(10.)'
				Block: smearhadesmomentum
				Block: smearhades3momentum
			Block: haft_pair
				Block: gethadespairacceptance
In: :HAFT:/lustre/hyihp/ngoetz/smash-analysis-extras/experimental_data/HADES_dilepton_filtering/readHAFT2.f90:haft_pair:gethadespairacceptance
get_parameters: got "name 'log' is not defined" on 'log(10.)'
				Block: setpairfilename
				Block: smearhadespair
In: :HAFT:/lustre/hyihp/ngoetz/smash-analysis-extras/experimental_data/HADES_dilepton_filtering/readHAFT2.f90:haft_pair:smearhadespair
get_parameters: got "name 'log' is not defined" on 'log(10.)'
In: :HAFT:/lustre/hyihp/ngoetz/smash-analysis-extras/experimental_data/HADES_dilepton_filtering/readHAFT2.f90:haft_pair:smearhadespair
get_parameters: got "invalid syntax (<string>, line 1)" on '(/0.05, 0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.8, 1.0, 1.2/)'
In: :HAFT:/lustre/hyihp/ngoetz/smash-analysis-extras/experimental_data/HADES_dilepton_filtering/readHAFT2.f90:haft_pair:smearhadespair
get_parameters: got "invalid syntax (<string>, line 1)" on '(/0.0077,-0.0082,-0.0125,-0.0120,-0.0114,-0.0106,-0.0098,-0.0085,-0.0078,-0.0075/)'
In: :HAFT:/lustre/hyihp/ngoetz/smash-analysis-extras/experimental_data/HADES_dilepton_filtering/readHAFT2.f90:haft_pair:smearhadespair
get_parameters: got "invalid syntax (<string>, line 1)" on '(/0.0820, 0.0460, 0.0260, 0.0210, 0.0190,0.0183, 0.0182, 0.0181, 0.0180, 0.0180/)'
In: :HAFT:/lustre/hyihp/ngoetz/smash-analysis-extras/experimental_data/HADES_dilepton_filtering/readHAFT2.f90:haft_pair:smearhadespair
get_parameters: got "invalid syntax (<string>, line 1)" on '(/13.5, 16.2, 19.9, 20.2, 19.2,18.0, 16.9, 14.8, 12.8, 11.0/)'
In: :HAFT:/lustre/hyihp/ngoetz/smash-analysis-extras/experimental_data/HADES_dilepton_filtering/readHAFT2.f90:haft_pair:smearhadespair
get_parameters: got "invalid syntax (<string>, line 1)" on '(/-10.0,-15.4,-20.4,-23.1,-22.3,-21.6,-20.6,-19.4,-18.2,-17.9/)'
In: :HAFT:/lustre/hyihp/ngoetz/smash-analysis-extras/experimental_data/HADES_dilepton_filtering/readHAFT2.f90:haft_pair:smearhadespair
get_parameters: got "invalid syntax (<string>, line 1)" on '(/18.1, 11.6, 10.4, 10.0, 9.4, 8.5, 7.8, 7.0, 6.2, 5.7/)'
				Block: setresolutionparameters
Post-processing (stage 2)...
	Block: HAFT
		Block: unknown_interface
			Block: haft_aux
				Block: kernel
				Block: samplegauss
				Block: samplemp
				Block: interpol
			Block: haft_single
				Block: unknown_type
				Block: unknown_type
				Block: setfilename
				Block: gethadesacceptance
				Block: smearhadesmomentum
				Block: smearhades3momentum
			Block: haft_pair
				Block: gethadespairacceptance
				Block: setpairfilename
				Block: smearhadespair
				Block: setresolutionparameters
Building modules...
	Building module "HAFT"...
		Constructing F90 module support for "haft_aux"...
		  Variables: pi
		Creating wrapper for Fortran function "kernel"("kernel")...
			Constructing wrapper function "haft_aux.kernel"...
			  kernel = kernel(u,mode)
		Creating wrapper for Fortran function "samplegauss"("samplegauss")...
			Constructing wrapper function "haft_aux.samplegauss"...
			  samplegauss = samplegauss(mean,sigma)
		Creating wrapper for Fortran function "samplemp"("samplemp")...
			Constructing wrapper function "haft_aux.samplemp"...
			  samplemp = samplemp(respar,ns)
		Creating wrapper for Fortran function "interpol"("interpol")...
			Constructing wrapper function "haft_aux.interpol"...
getarrdims:warning: assumed shape array, using 0 instead of '*'
getarrdims:warning: assumed shape array, using 0 instead of '*'
			  interpol = interpol(x,xtab,ytab,n)
		Constructing F90 module support for "haft_single"...
f90mod_rules.buildhooks: skipping type unknown_type
f90mod_rules.buildhooks: skipping type unknown_type
			Constructing wrapper function "haft_single.setfilename"...
			  setfilename(name)
		Creating wrapper for Fortran function "gethadesacceptance"("gethadesacceptance")...
			Constructing wrapper function "haft_single.gethadesacceptance"...
			  gethadesacceptance = gethadesacceptance(pid,p0,theta0,phi0,[mode])
			Constructing wrapper function "haft_single.smearhadesmomentum"...
			  smearhadesmomentum(p,mode,pid)
			Constructing wrapper function "haft_single.smearhades3momentum"...
			  smearhades3momentum(mom3,mode,pid)
		Constructing F90 module support for "haft_pair"...
		Creating wrapper for Fortran function "gethadespairacceptance"("gethadespairacceptance")...
			Constructing wrapper function "haft_pair.gethadespairacceptance"...
			  gethadespairacceptance = gethadespairacceptance(mass0,pt0,rap0,[mode])
			Constructing wrapper function "haft_pair.setpairfilename"...
			  setpairfilename(name)
			Constructing wrapper function "haft_pair.smearhadespair"...
			  smearhadespair(pair,mode)
			Constructing wrapper function "haft_pair.setresolutionparameters"...
			  setresolutionparameters(mode,a,b)
	Wrote C/API module "HAFT" to file "/tmp/tmp5vplxus_/src.linux-x86_64-3.10/HAFTmodule.c"
	Fortran 90 wrappers are saved to "/tmp/tmp5vplxus_/src.linux-x86_64-3.10/HAFT-f2pywrappers2.f90"
  adding '/tmp/tmp5vplxus_/src.linux-x86_64-3.10/fortranobject.c' to sources.
  adding '/tmp/tmp5vplxus_/src.linux-x86_64-3.10' to include_dirs.
copying /usr/lib/python3/dist-packages/numpy/f2py/src/fortranobject.c -> /tmp/tmp5vplxus_/src.linux-x86_64-3.10
copying /usr/lib/python3/dist-packages/numpy/f2py/src/fortranobject.h -> /tmp/tmp5vplxus_/src.linux-x86_64-3.10
  adding '/tmp/tmp5vplxus_/src.linux-x86_64-3.10/HAFT-f2pywrappers2.f90' to sources.
build_src: building npy-pkg config files
running build_ext
customize UnixCCompiler
customize UnixCCompiler using build_ext
get_default_fcompiler: matching types: '['gnu95', 'intel', 'lahey', 'pg', 'nv', 'absoft', 'nag', 'vast', 'compaq', 'intele', 'intelem', 'gnu', 'g95', 'pathf95', 'nagfor', 'fujitsu']'
customize Gnu95FCompiler
Found executable /usr/bin/gfortran
customize Gnu95FCompiler
customize Gnu95FCompiler using build_ext
building 'HAFT' extension
compiling C sources
C compiler: x86_64-linux-gnu-gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC

creating /tmp/tmp5vplxus_/tmp
creating /tmp/tmp5vplxus_/tmp/tmp5vplxus_
creating /tmp/tmp5vplxus_/tmp/tmp5vplxus_/src.linux-x86_64-3.10
compile options: '-DNPY_DISABLE_OPTIMIZATION=1 -I/tmp/tmp5vplxus_/src.linux-x86_64-3.10 -I/usr/lib/python3/dist-packages/numpy/core/include -I/usr/include/python3.10 -c'
x86_64-linux-gnu-gcc: /tmp/tmp5vplxus_/src.linux-x86_64-3.10/HAFTmodule.c
x86_64-linux-gnu-gcc: /tmp/tmp5vplxus_/src.linux-x86_64-3.10/fortranobject.c
In file included from /usr/lib/python3/dist-packages/numpy/core/include/numpy/ndarraytypes.h:1969,
                 from /usr/lib/python3/dist-packages/numpy/core/include/numpy/ndarrayobject.h:12,
                 from /usr/lib/python3/dist-packages/numpy/core/include/numpy/arrayobject.h:4,
                 from /tmp/tmp5vplxus_/src.linux-x86_64-3.10/fortranobject.h:13,
                 from /tmp/tmp5vplxus_/src.linux-x86_64-3.10/fortranobject.c:2:
/usr/lib/python3/dist-packages/numpy/core/include/numpy/npy_1_7_deprecated_api.h:17:2: warning: #warning "Using deprecated NumPy API, disable it with " "#define NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" [-Wcpp]
   17 | #warning "Using deprecated NumPy API, disable it with " \
      |  ^~~~~~~
In file included from /usr/lib/python3/dist-packages/numpy/core/include/numpy/ndarraytypes.h:1969,
                 from /usr/lib/python3/dist-packages/numpy/core/include/numpy/ndarrayobject.h:12,
                 from /usr/lib/python3/dist-packages/numpy/core/include/numpy/arrayobject.h:4,
                 from /tmp/tmp5vplxus_/src.linux-x86_64-3.10/fortranobject.h:13,
                 from /tmp/tmp5vplxus_/src.linux-x86_64-3.10/HAFTmodule.c:16:
/usr/lib/python3/dist-packages/numpy/core/include/numpy/npy_1_7_deprecated_api.h:17:2: warning: #warning "Using deprecated NumPy API, disable it with " "#define NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" [-Wcpp]
   17 | #warning "Using deprecated NumPy API, disable it with " \
      |  ^~~~~~~
/tmp/tmp5vplxus_/src.linux-x86_64-3.10/HAFTmodule.c:134:12: warning: ‘f2py_size’ defined but not used [-Wunused-function]
  134 | static int f2py_size(PyArrayObject* var, ...)
      |            ^~~~~~~~~
compiling Fortran 90 module sources
Fortran f77 compiler: /usr/bin/gfortran -Wall -g -ffixed-form -fno-second-underscore -fPIC -O3 -funroll-loops
Fortran f90 compiler: /usr/bin/gfortran -Wall -g -fno-second-underscore -fPIC -O3 -funroll-loops
Fortran fix compiler: /usr/bin/gfortran -Wall -g -ffixed-form -fno-second-underscore -Wall -g -fno-second-underscore -fPIC -O3 -funroll-loops
creating /tmp/tmp5vplxus_/lustre
creating /tmp/tmp5vplxus_/lustre/hyihp
creating /tmp/tmp5vplxus_/lustre/hyihp/ngoetz
creating /tmp/tmp5vplxus_/lustre/hyihp/ngoetz/smash-analysis-extras
creating /tmp/tmp5vplxus_/lustre/hyihp/ngoetz/smash-analysis-extras/experimental_data
creating /tmp/tmp5vplxus_/lustre/hyihp/ngoetz/smash-analysis-extras/experimental_data/HADES_dilepton_filtering
compile options: '-I/tmp/tmp5vplxus_/src.linux-x86_64-3.10 -I/usr/lib/python3/dist-packages/numpy/core/include -I/usr/include/python3.10 -c'
extra options: '-J/tmp/tmp5vplxus_/ -I/tmp/tmp5vplxus_/'
gfortran:f90: /lustre/hyihp/ngoetz/smash-analysis-extras/experimental_data/HADES_dilepton_filtering/readHAFT2.f90
/lustre/hyihp/ngoetz/smash-analysis-extras/experimental_data/HADES_dilepton_filtering/readHAFT2.f90:857:18:

  857 |       mom4(1:3) = p(1:3)
      |                  1
Warning: Possible change of value in conversion from REAL(8) to REAL(4) at (1) [-Wconversion]
/lustre/hyihp/ngoetz/smash-analysis-extras/experimental_data/HADES_dilepton_filtering/readHAFT2.f90:858:16:

  858 |       mom4(4) = p(0)
      |                1
Warning: Possible change of value in conversion from REAL(8) to REAL(4) at (1) [-Wconversion]
compiling Fortran sources
Fortran f77 compiler: /usr/bin/gfortran -Wall -g -ffixed-form -fno-second-underscore -fPIC -O3 -funroll-loops
Fortran f90 compiler: /usr/bin/gfortran -Wall -g -fno-second-underscore -fPIC -O3 -funroll-loops
Fortran fix compiler: /usr/bin/gfortran -Wall -g -ffixed-form -fno-second-underscore -Wall -g -fno-second-underscore -fPIC -O3 -funroll-loops
compile options: '-I/tmp/tmp5vplxus_/src.linux-x86_64-3.10 -I/usr/lib/python3/dist-packages/numpy/core/include -I/usr/include/python3.10 -c'
extra options: '-J/tmp/tmp5vplxus_/ -I/tmp/tmp5vplxus_/'
gfortran:f90: /tmp/tmp5vplxus_/src.linux-x86_64-3.10/HAFT-f2pywrappers2.f90
/tmp/tmp5vplxus_/src.linux-x86_64-3.10/HAFT-f2pywrappers2.f90:28:43:

   28 |       subroutine f2pywrap_haft_aux_interpol (interpolf2pywrap, x, xtab, &
      |                                           1
......
   63 |       subroutine f2pywrap_haft_aux_interpol (interpolf2pywrap, interpol,&
      |                                           2
Warning: Rank mismatch in argument 'x' (0/1) between (1) and (2)
/tmp/tmp5vplxus_/src.linux-x86_64-3.10/HAFT-f2pywrappers2.f90:5:41:

    5 |       subroutine f2pywrap_haft_aux_kernel (kernelf2pywrap, u, mode)
      |                                         1
......
   42 |       subroutine f2pywrap_haft_aux_kernel (kernelf2pywrap, kernel, u, mo&
      |                                         2
Warning: Type mismatch in argument 'u' (REAL(4)/INTEGER(4)) between (1) and (2)
/tmp/tmp5vplxus_/src.linux-x86_64-3.10/HAFT-f2pywrappers2.f90:12:46:

   12 |       subroutine f2pywrap_haft_aux_samplegauss (samplegaussf2pywrap, mea&
      |                                              1
......
   49 |       subroutine f2pywrap_haft_aux_samplegauss (samplegaussf2pywrap, sam&
      |                                              2
Warning: 'f2pywrap_haft_aux_samplegauss' has the wrong number of arguments between (1) and (2)
/tmp/tmp5vplxus_/src.linux-x86_64-3.10/HAFT-f2pywrappers2.f90:20:43:

   20 |       subroutine f2pywrap_haft_aux_samplemp (samplempf2pywrap, respar, n&
      |                                           1
......
   56 |       subroutine f2pywrap_haft_aux_samplemp (samplempf2pywrap, samplemp,&
      |                                           2
Warning: Rank mismatch in argument 'samplemp' (0/1) between (1) and (2)
/tmp/tmp5vplxus_/src.linux-x86_64-3.10/HAFT-f2pywrappers2.f90:78:56:

   78 |       subroutine f2pywrap_haft_single_gethadesacceptance (gethadesaccept&
      |                                                        1
......
   96 |       subroutine f2pywrap_haft_single_gethadesacceptance (gethadesaccept&
      |                                                        2
Warning: Type mismatch in argument 'gethadesacceptance' (REAL(4)/INTEGER(4)) between (1) and (2)
/tmp/tmp5vplxus_/src.linux-x86_64-3.10/HAFT-f2pywrappers2.f90:112:58:

  112 |       subroutine f2pywrap_haft_pair_gethadespairacceptance (gethadespair&
      |                                                          1
......
  129 |       subroutine f2pywrap_haft_pair_gethadespairacceptance (gethadespair&
      |                                                          2
Warning: Type mismatch in argument 'rap0' (REAL(4)/INTEGER(4)) between (1) and (2)
/usr/bin/gfortran -Wall -g -Wall -g -shared /tmp/tmp5vplxus_/tmp/tmp5vplxus_/src.linux-x86_64-3.10/HAFTmodule.o /tmp/tmp5vplxus_/tmp/tmp5vplxus_/src.linux-x86_64-3.10/fortranobject.o /tmp/tmp5vplxus_/lustre/hyihp/ngoetz/smash-analysis-extras/experimental_data/HADES_dilepton_filtering/readHAFT2.o /tmp/tmp5vplxus_/tmp/tmp5vplxus_/src.linux-x86_64-3.10/HAFT-f2pywrappers2.o -L/usr/lib/gcc/x86_64-linux-gnu/11 -L/usr/lib/gcc/x86_64-linux-gnu/11 -lgfortran -o ./HAFT.cpython-310-x86_64-linux-gnu.so
get_useparameters: mapping for {'only': 1, 'map': {'kernel': 'kernel'}} not impl.get_useparameters: mapping for {'only': 1, 'map': {'kernel': 'kernel'}} not impl.get_useparameters: mapping for {'only': 1, 'map': {'interpol': 'interpol', 'samplegauss': 'samplegauss', 'samplemp': 'samplemp'}} not impl.Removing build directory /tmp/tmp5vplxus_

It looks to me like two distinct issues:

  • one seems to involve unstable particles and might be related to recent changes
  • The other one seems to be an f2py issue, potentially from some version changes in the container (?).

I have never myself worked with HAFT, nor do I have an overview of the changes in the decaymodes. I tag everyone here whom I suspect to have more knowledge about this issue, and I would appreciate any form of support in fixing this.

@Cazono
Copy link

Cazono commented Dec 22, 2024

I do not think D*(2007)⁺ exists. My guess is that it being merged with D∗(2010)+ does not work. Removing the pdgcode for D∗(2010)+ might fix it.

@NGoetz
Copy link
Member Author

NGoetz commented Dec 22, 2024

I followed this advice and gave the dilepton target another particle list, but now it complains about D*(2460) with the same error. I also realised that probably there is no issue with HAFT, it's only compiler warnings. Therefore, it seems we have to figure out what the correct particle lists and decaymodes are for the dilepton target after the recent changes.

@RenHirayama
Copy link
Member

My guess is that the particles.txt/decaymodes.txt are not correct for the dilepton target. I'll take a look.

@RenHirayama
Copy link
Member

RenHirayama commented Dec 23, 2024

Yeah, this error happens because we did not update https://github.com/smash-transport/smash-analysis/blob/develop/test/dileptons/decaymodes.txt, I believe that the fix is just copying the files from the release branch. This should be done for other targets as well (if this is not automatic), because of Carl's changes to resonance properties.

@NGoetz
Copy link
Member Author

NGoetz commented Dec 23, 2024

Normally, the targets use the default of SMASH:

Targets which do not use either custom particle or decay list: energy scan, afterburner, FOPI, angular_distributions,cross_sections, densities
Targets with custom decay and particle lists: detailed_balance
Targets with custom decaymodes: dileptons, elastic box

I am copying the decay file for the dileptons, but for other targets I need someone with knowledge of the matter to tell me if something should be modified, and if yes, in which way.

@RenHirayama
Copy link
Member

also the config files for dileptons require the "Oscar2013_bin" format, instead of the old "Binary". I think these were not properly implemented in the release branch @AxelKrypton, as SMASH throws

[19'32'02] ERROR      Experiment     : Unknown combination of format (Oscar2013_bin) and content (Dileptons). Fix the config.

Should we deal with this on the SMASH side? Or leave the smash-analysis with "Binary"? I prefer the former for consistency.

@NGoetz
Copy link
Member Author

NGoetz commented Dec 23, 2024

If I understood your error correctly, does this mean replacing "Binary" with "Oscar2013_bin" caused this issue?

@RenHirayama
Copy link
Member

RenHirayama commented Dec 23, 2024

but for other targets I need someone with knowledge of the matter to tell me if something should be modified, and if yes, in which way.

  • elastic_box: no need to change, every decay is turned off anyway
  • detailed_balance: you need to change N_K_Lambda and thermal_box, as these include the recently changed particles. For the latter I believe you can just copy the files (maybe with minor adjustments with commenting out dilepton branches). For the former, you need to change the specific resonances contained in the file (nucleon and Lambda resonances).

Of course, maybe I missed something. @Carl-Rosenkvist did your changes affect meson resonances?

Should we deal with this on the SMASH side? Or leave the smash-analysis with "Binary"? I prefer the former for consistency.

But if I understand your error correctly, does this mean replacing "Binary" with "Oscar2013_bin" causes this issue?

Yeah I think so. For now, just revert the configs back to "Binary" in case you get the same error, since this is a key change and would not affect the analysis outcome.

@NGoetz
Copy link
Member Author

NGoetz commented Dec 23, 2024

Okay I will test the dilepton target. For the other two, I will wait for @Carl-Rosenkvist to confirm which changes are needed.

@Carl-Rosenkvist
Copy link
Collaborator

Carl-Rosenkvist commented Dec 27, 2024

Of course, maybe I missed something. @Carl-Rosenkvist did your changes affect meson resonances?

No, I only changed nucleon resonances parameters.

Yeah I think so. For now, just revert the configs back to "Binary" in case you get the same error, since this is a key change and would not affect the analysis outcome.

But then one would need to specify quantities? Empty quantities and Binary would produce a throw, right?

@NGoetz
Copy link
Member Author

NGoetz commented Dec 27, 2024

But then one would need to specify quantities? Empty quantities and Binary would produce a throw, right?
I think the dilepton output was a special case there.

Regarding possible changes for detailed balance, I just noticed that we never changed the particle and decay lists since at least SMASH 1.6. Should we really start that now?

@RenHirayama
Copy link
Member

RenHirayama commented Dec 30, 2024

Should we really start that now?

Yes, actually we should've started whenever there was a change to the default input particles. For most targets this is the case automatically, but the abovementioned ones were hardcoded, so I imagine we just forgot to update them.

@AxelKrypton
Copy link
Member

also the config files for dileptons require the "Oscar2013_bin" format, instead of the old "Binary". I think these were not properly implemented in the release branch @AxelKrypton, as SMASH throws

[19'32'02] ERROR      Experiment     : Unknown combination of format (Oscar2013_bin) and content (Dileptons). Fix the config.

Should we deal with this on the SMASH side? Or leave the smash-analysis with "Binary"? I prefer the former for consistency.

According to the present documentation

image

the quantities can be specified for Particles and Collisions only and Oscar2013_bin is an alias for Binary plus a list of Quantities. Therefore I am against using the alias for Dileptons without implementing there a custom output, which we will do next anyway. Maybe, we could change in the second sub-item the sentence "Also for binary format it is possible to customize the quantities to be printed into the file." to a more content-specific one in order to stress that the customisation is only possible for those two contents. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants