Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module Config Promotion Will Promote Current Input #258

Closed
crokita opened this issue Aug 10, 2021 · 0 comments · Fixed by #259
Closed

Module Config Promotion Will Promote Current Input #258

crokita opened this issue Aug 10, 2021 · 0 comments · Fixed by #259

Comments

@crokita
Copy link
Contributor

crokita commented Aug 10, 2021

Bug Report

All changes that get saved in the module config window are based on the user's current edited changes in the webpage. This is fine for saving items to staging, but when promoting to production the settings saved in the database in staging get ignored because it will submit whatever the user edits on the webpage instead.

Reproduction Steps
  1. Save a change in staging
  2. Make a change again
  3. Do not click save
  4. Click promote
  5. The current input will be saved as production and not the previously saved staging record
Expected Behavior

The saved staging state should be promoted

Observed Behavior

The current state on the webpage gets promoted

OS, Browser & Version Information

All versions and browsers affected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant