Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better API response for not passing in integers for id properties of requests #237

Closed
crokita opened this issue Apr 7, 2021 · 0 comments · Fixed by #239
Closed

Better API response for not passing in integers for id properties of requests #237

crokita opened this issue Apr 7, 2021 · 0 comments · Fixed by #239
Labels
bug

Comments

@crokita
Copy link
Contributor

crokita commented Apr 7, 2021 •
edited
Loading

Bug Report

For some requests that allow a user to pass in an id to query, passing in a string bypasses validation and the server responds with a 500.

Reproduction Steps
  1. Query for GET applications, POST applications/action, GET functional groups or GET consumer messages using ids
  2. Pass in a string for the id value
Expected Behavior
  1. Server invalidates the request because it's a string
Observed Behavior
  1. Server attempts to find the id despite being the wrong type
@crokita crokita changed the title Better API response for not passing in integers for id properties of GETs Better API response for not passing in integers for id properties of requests Apr 7, 2021
@crokita crokita mentioned this issue Apr 7, 2021
Merged
@renonick87 renonick87 mentioned this issue Apr 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Give better errors to sending non integer ids smartdevicelink/sdl_server
2 participants
@crokita @jordynmackool