Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SdlArtwork clone issue #546

Closed
crokita opened this issue Jun 24, 2022 · 1 comment
Closed

SdlArtwork clone issue #546

crokita opened this issue Jun 24, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@crokita
Copy link
Contributor

crokita commented Jun 24, 2022

Bug Summary

See original report from Java team

Cloning an SdlArtwork after having the artwork set its _imageRPC property (ex. through setPrimaryGraphic) gets the property passed to the clone as well. When trying to set the file name to something else and sending it again the _imageRPC is cached and will not change its value. The FileManager doesn't use _imageRPC but the text and graphic operation class does and this causes the wrong image to show up on the HMI.

Reproduction Steps

  1. Send an SdlArtwork via setPrimaryGraphic
  2. Clone the SdlArtwork
  3. Change its file name
  4. Send it again via setPrimaryGraphic

Expected Behavior:
TextAndGraphicUpdateOperation uses the new file name in its _imageRPC and the right image is uploaded

Observed Behavior:
TextAndGraphicUpdateOperation uses the old file name in its _imageRPC and the wrong image is uploaded

Which projects have you seen this bug on?

No response

JavaScript Version(s)

1.5.0

sdl_javascript Version

1.5.0

Testing Environment(s)

Manticore v2.10.0

Relevant log output

No response

@crokita crokita added the bug Something isn't working label Jun 24, 2022
@theresalech
Copy link
Collaborator

Closed via #549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants