Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to Send Voice Command with No Strings Fails to Log Error #529

Closed
crokita opened this issue Mar 30, 2022 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@crokita
Copy link
Contributor

crokita commented Mar 30, 2022

Bug Summary

When trying to send a VoiceCommand containing no or invalid command strings using VoiceCommandManager, it fails to send as expected, but no error is logged to explain this behavior to the app developer.

Reproduction Steps

  1. Create a voice command array with some voice commands that have empty or blank strings.
  2. Make one of the voice commands contain only invalid strings
  3. Send the voice command array using setVoiceCommands

Expected Behavior:
The library should log that an invalid voice command string was used in a voice command. The library should log that a voice command will not be uploaded due to no valid voice command strings.

Observed Behavior:
Nothing is logged.

Which projects have you seen this bug on?

Vanilla JavaScript, Node.js

JavaScript Version(s)

1.5.0

Testing Environment(s)

SDL Core v8.0.0 + Generic_HMI v0.11.0

Relevant log output

No response

@crokita crokita added the bug Something isn't working label Mar 30, 2022
@theresalech
Copy link
Collaborator

Closed via #530

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants