Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScreenManager does not reinitialize SoftButton ID Sets on reconnection #501

Closed
renonick87 opened this issue Oct 20, 2021 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@renonick87
Copy link
Contributor

Bug Report

When the library disconnects from core, the ScreenManager sets the _softButtonIDBySoftButtonManager and _softButtonIDByAlertManager to null, but these Sets are not reinitialized on reconnection. This causes errors in the library from trying to call Set methods on a null value.

Reproduction Steps
  1. Connect and disconnect an app by sending RegisterAppInterface and UnregisterAppInterface RPCs.
  2. Reconnect the app with a RegisterAppInterface.
  3. Display a list of SoftButtonObjects with the ScreenManager's setSoftButtonObjects method.
screenManager.setSoftButtonObjects([softButtonObject1, softButtonObject2, softButtonObject3]);
Expected Behavior

The SoftButtons are displayed in the HMI.

Observed Behavior

The SoftButtons are not displayed in the HMI and error is logged from the library.

Browser & Version Information
  • SDL JavaScript Suite Module: node
  • SDL JavaScript Version: v1.5.0 RC
  • Testing Against: Manticore v2.8.0
@jordynmackool jordynmackool added the bug Something isn't working label Oct 22, 2021
@theresalech
Copy link
Collaborator

Closed via #502

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants