Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong ChoiceSet listeners being called when queueing PresentChoiceSetOperations #473

Closed
renonick87 opened this issue Jul 13, 2021 · 0 comments · Fixed by #477
Closed

Wrong ChoiceSet listeners being called when queueing PresentChoiceSetOperations #473

renonick87 opened this issue Jul 13, 2021 · 0 comments · Fixed by #477

Comments

@renonick87
Copy link
Contributor

Bug Report

If multiple PresentChoiceSetOperations are queued with the ChoiceSetManager, then the listeners from later ChoiceSets can end up being called on earlier ChoiceSets. This is likely because the operation class is using a reference to the manager's current pending ChoiceSet instead of cloning the data.

Reproduction Steps
  1. Present a ChoiceSet with the manager and while it's being presented, queue another ChoiceSet to be presented. Provide an onChoiceSelected listener for both.
  2. In the HMI, select one of the available choices from the first ChoiceSet.
Expected Behavior

The listener for the first ChoiceSet is called.

Observed Behavior

The listener for the second ChoiceSet is called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant