Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid deleting and setting identical voice commands #433

Closed
theresalech opened this issue Apr 28, 2021 · 0 comments · Fixed by #438
Closed

Avoid deleting and setting identical voice commands #433

theresalech opened this issue Apr 28, 2021 · 0 comments · Fixed by #438
Labels
bug Something isn't working

Comments

@theresalech
Copy link
Collaborator

Bug Report

Currently, setting voice commands doesn't check for a diff of which voice commands are in the old and new lists. This results in a case where if voice commands are set like so:

voiceCommands = [command1, command2, command3]
voiceCommands = [command1, command2, command3, command 4]

What will happen is command1/2/3 will be set to the head unit, then command1/2/3 will be deleted from the head unit, then command1/2/3/4 will be set to the head unit.

Because voice commands can be so slow to process, we should diff and only set / delete what is necessary instead of taking an all-or-nothing approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant