Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

voiceCommand that contains no string should be removed #431

Closed
theresalech opened this issue Apr 28, 2021 · 0 comments · Fixed by #439
Closed

voiceCommand that contains no string should be removed #431

theresalech opened this issue Apr 28, 2021 · 0 comments · Fixed by #439
Labels
bug Something isn't working

Comments

@theresalech
Copy link
Collaborator

Bug Report

When a voice command contains no strings, it should not be sent in an update

Reproduction Steps
  1. voiceCommandA = ["Test 1"];
  2. voiceCommandB = [];
  3. Upload voiceCommands
Expected Behavior

currentVoiceCommands = [voiceCommandA];

Observed Behavior

currentVoiceCommands = [voiceCommandA, voiceCommandB];
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for voice command that contains no string should be removed smartdevicelink/sdl_javascript_suite
1 participant
@theresalech