Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter constants to use common style #711

Closed
joeljfischer opened this issue Aug 25, 2017 · 0 comments
Closed

Alter constants to use common style #711

joeljfischer opened this issue Aug 25, 2017 · 0 comments
Assignees
Labels
bug A defect in the library
Milestone

Comments

@joeljfischer
Copy link
Contributor

Bug Report

Currently our constants appear to be defined in a variety of styles.

// SDLRPCPayload
const NSUInteger RPC_HEADER_SIZE = 12;
// SDLIAPSession
NSString *const IOStreamThreadName = @"com.smartdevicelink.iostream";
NSTimeInterval const streamThreadWaitSecs = 1.0;
// SDLIAPTransport
NSString *const LegacyProtocolString = @"com.ford.sync.prot0";
NSString *const ControlProtocolString = @"com.smartdevicelink.prot0";
NSString *const IndexedProtocolStringPrefix = @"com.smartdevicelink.prot";
NSString *const MultiSessionProtocolString = @"com.smartdevicelink.multisession";
NSString *const BackgroundTaskName = @"com.sdl.transport.iap.backgroundTask";
Expected Behavior

The SDLIAPTransport style.

Observed Behavior

A variety of styles

@joeljfischer joeljfischer added the bug A defect in the library label Aug 25, 2017
@joeljfischer joeljfischer added this to the 5.0.0 milestone Aug 25, 2017
@joeljfischer joeljfischer self-assigned this Aug 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library
Projects
None yet
Development

No branches or pull requests

1 participant