Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDL-0005] SDLRPCStruct + all subclasses [initWithDictionary] method should take an NSDictionary #151

Closed
joeljfischer opened this issue Mar 30, 2015 · 0 comments
Closed

[SDL-0005] SDLRPCStruct + all subclasses [initWithDictionary] method should take an NSDictionary #151

joeljfischer opened this issue Mar 30, 2015 · 0 comments
Labels
best practice Not a defect but something that should be improved anyway bug A defect in the library
Milestone
5.0.0

Comments

@joeljfischer
Copy link
Contributor

joeljfischer commented Mar 30, 2015 •
edited
Loading

Part of Proposal SDL-0005.

Currently takes a mutable dictionary, which it doesn't have to. The dictionary should also be copied in since the consumer could theoretically still pass a mutable dictionary.
@joeljfischer joeljfischer added bug A defect in the library best practice Not a defect but something that should be improved anyway labels Mar 30, 2015
@joeljfischer joeljfischer added this to the 4.0.0 milestone Mar 30, 2015
@joeljfischer joeljfischer changed the title SDLRPCMessage + all subclasses [initWithDictionary] method should take an NSDictionary SDLRPCStruct + all subclasses [initWithDictionary] method should take an NSDictionary Mar 30, 2015
@joeljfischer joeljfischer modified the milestones: 5.0.0, 4.0.0 May 14, 2015
@joeljfischer joeljfischer modified the milestones: 4.1.0, 5.0.0 Jul 31, 2015
@joeljfischer joeljfischer modified the milestones: 5.0.0, 4.X Jan 25, 2016
@asm09fsu asm09fsu mentioned this issue Sep 22, 2016
Merged
@joeljfischer joeljfischer changed the title SDLRPCStruct + all subclasses [initWithDictionary] method should take an NSDictionary [SDL-0005] SDLRPCStruct + all subclasses [initWithDictionary] method should take an NSDictionary Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
best practice Not a defect but something that should be improved anyway bug A defect in the library
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
1 participant
@joeljfischer