Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHA-256 not supported for RSA encryption #11

Closed
clarkmcc opened this issue Oct 23, 2023 · 4 comments · Fixed by #12
Closed

SHA-256 not supported for RSA encryption #11

clarkmcc opened this issue Oct 23, 2023 · 4 comments · Fixed by #12
Assignees

Comments

@clarkmcc
Copy link

I'm trying to verify the Azure attestation signature using this library and am able to successfully parse the signature, but validation fails with the following error.

pkcs7: unsupported digest "1.2.840.113549.1.1.11" for encryption algorithm "1.2.840.113549.1.1.1"
@hslatman
Copy link
Member

hslatman commented Oct 23, 2023

Hey @clarkmcc, thank you for opening the issue. Looks like this case wasn't handled yet. I've opened a PR: #12. Need to verify the allowed algorithms. The example from Microsoft succeeds validation with this single algorithm patched.

@clarkmcc
Copy link
Author

Fantastic news! Thanks for the quick turnaround.

@hslatman
Copy link
Member

@clarkmcc the PR was merged. Note that we've also changed the module name in #16, so you should now be able to import it as github.com/smallstep/pkcs7.

@clarkmcc
Copy link
Author

I meant to ask about that. I had to jump through some hoops to work around that, so this is a great improvement! Thanks for your work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants