-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add builder info to provenance #89
Comments
As of slsa-framework/slsa-github-generator-go#16 we capture the runner's Image details (GitHub tag) in the materials. |
Unfortunately the virtual-environment itself does not seem to include the SHA of the commit the tag references, but it's highly desirable to include this in order to list fully traceable information about the images in the provenance (tags can be replaced, after all). One option is to query the ref the tag currently points to at provenance generation time with a programmatic equivalent to:
However, what we really want is the SHA at the time the image was built. Unless anyone has any smarter ideas, I think I'll file a feature request against actions/virtual-environments to include the SHA commit hash matching the tag into the environment or the /imagegeneration/imagedata.json file. |
+1 on asking them to add it. How about: |
The actions/virtual-environments repository has fairly rigid issue templates so I started a discussion instead: actions/runner-images#5483 |
I'm curious: are we certain that the virtual runner used in the provenance generation VM is the same as the one used by the actual build? Similarly: If we want to report the compiler hash used during compilation, we may also need to validate they are the same in the build VM and the dry run VM. Or we move to container image, maybe something like https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-running-a-job-within-a-container? |
We should investigate capturing runner OS's information if available in /etc
Maybe also provide an SBOM of our builder, etc.
GitHub may also expose info. In the logs, for example, VM setup shows info like:
The text was updated successfully, but these errors were encountered: