Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: remove the "arch" from provenance #23

Closed
Tracked by #75
laurentsimon opened this issue Mar 30, 2022 · 4 comments
Closed
Tracked by #75

BUG: remove the "arch" from provenance #23

laurentsimon opened this issue Mar 30, 2022 · 4 comments
Assignees
@joshuagl

Comments

@laurentsimon
Copy link
Contributor

We set the "arch" based on the value provided by GOOS defined by the user, but this is not necessarily the same as the builder's arch, especially since Go support cross compilation.

If we decide to keep the "arch", we should get it dynamically from the machine
@laurentsimon
Copy link
Contributor Author

@joshuagl do you want to tackle this issue as part of #16?

@joshuagl
Copy link
Member

Absolutely. Though I won't get to it before next week.

@joshuagl joshuagl self-assigned this Mar 30, 2022
@laurentsimon
Copy link
Contributor Author

SG, thanks!

@laurentsimon laurentsimon mentioned this issue May 20, 2022
Closed
22 tasks
@joshuagl
Copy link
Member

Since #16 we now read arch from the runner's environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshuagl joshuagl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshuagl @laurentsimon