Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle updates in verifier CLI arguments and subcommands #97

Closed
asraa opened this issue Sep 1, 2022 · 0 comments · Fixed by #100
Closed

Handle updates in verifier CLI arguments and subcommands #97

asraa opened this issue Sep 1, 2022 · 0 comments · Fixed by #100

Comments

@asraa
Copy link
Collaborator

asraa commented Sep 1, 2022

After slsa-framework/slsa-verifier#231

we will have two sub-commands added to the verifier: verify-artifact and verify-container.

Then, we will also have the following transformation on argument names:

# provenance -> provenance-path
# source -> source-uri
# tag -> source-tag
# versioned-tag -> source-versioned-tag
# branch -> source-branch
# workflow-input -> build-workflow-input

WDYT about making a e2e_verifier_arg_transformer $tag that returns a function who's signature is func $argument and returns the correct argument name? Likewise, we can make e2e_verifier_subcommand_transformer $tag that returns a func whos signature is func $artifact-type and returns either verify-artifact or "" for previous versions?

I am not so well-versed in bash scripting, but I think I can do something like that.

@asraa asraa changed the title Handle updates in verifier CLI Handle updates in verifier CLI arguments and subcommands Sep 1, 2022
@asraa asraa closed this as completed in #100 Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant