You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've searched for any related issues and avoided creating a duplicate issue.
Bug Report
The tableview that I'm displaying in the PanModal has editing capabilities. If I try to move an item from the top of the list downwards, the modal thinks I'm swiping downwards, dismissing the modal
Reproducible in:
Xcode 11.3.1
PanModal version:
1.2.6
iOS version:
iOS 13.3.1
Steps to reproduce:
Create a UITableViewController, and make it conform to PanModalPresentable. Set the panScrollable property to be the tableView
Add editing and move functionality to the tableView
Display the panModal view, and try to move the first cell down the list
Expected result:
The item is able to be moved downwards successfully.
Actual result:
The panModal view is dismissed
Attachments:
Something to note here: Our designers want the cell to have swipe to delete and move functionality, so the move is being done by pressing and holding on a cell, and then dragging it. I'm not sure if this is what is causing the weird behavior or not. I'm still investigating.
The text was updated successfully, but these errors were encountered:
Thanks for reporting and apologies for the delay. I think I may know what's causing this - the pan gesture recognizer on the pan modal would still be active when editing the tableView list so it thinks you want to dismiss instead of just edit. The quickest way to solve this would be to return false in func shouldRespond(to panModalGestureRecognizer: UIPanGestureRecognizer) -> Bool when editing begins on the tableView - that should stop the pan modal from dismissing. May/not be ideal but let me know if this works.
@ste57 I want to disable the automatic dismiss of the panmodal too, I have imlemented the function mentioned above return false in func shouldRespond(to panModalGestureRecognizer: UIPanGestureRecognizer) -> Bool
but it's not getting called when I pull the panmodal view down.
Description
Describe your issue here.
What type of issue is this? (place an
x
in one of the[ ]
)Requirements (place an
x
in each of the[ ]
)Bug Report
The tableview that I'm displaying in the PanModal has editing capabilities. If I try to move an item from the top of the list downwards, the modal thinks I'm swiping downwards, dismissing the modal
Reproducible in:
Xcode 11.3.1
PanModal version:
1.2.6
iOS version:
iOS 13.3.1
Steps to reproduce:
Expected result:
The item is able to be moved downwards successfully.
Actual result:
The panModal view is dismissed
Attachments:
Something to note here: Our designers want the cell to have swipe to delete and move functionality, so the move is being done by pressing and holding on a cell, and then dragging it. I'm not sure if this is what is causing the weird behavior or not. I'm still investigating.
The text was updated successfully, but these errors were encountered: