Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conform to Kafka id naming rules #23

Closed
agis opened this issue Jul 18, 2017 · 1 comment
Closed

Conform to Kafka id naming rules #23

agis opened this issue Jul 18, 2017 · 1 comment
Labels
bug

Comments

@agis
Copy link
Contributor

agis commented Jul 18, 2017 •
edited
Loading

Kafka only allows [a-zA-Z0-9\\._\\-] being used in group.id and client.id (see this and this). Doing otherwise causes weird errors when attempting to set the client.id for example (eg. Unknown broker error) .

We should make sure our internal IDs are constructed according to Kafka rules.
@agis agis added the bug label Jul 18, 2017
@agis agis mentioned this issue Jul 18, 2017
Closed
@agis
Copy link
Contributor Author

agis commented Jul 20, 2017

We took a different approach by keeping our IDs as they were and only using portions of them to Kafka: 2b998d3.

@agis agis closed this as completed Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@agis