You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I find it unclear from the name what updateStatus() is supposed to do, which makes it difficult to remember when it is necessary to call it.
From the code, it looks like it can either
Whitelist an application that has passed the application period without a challenge
If there is a challenge that has finished its voting period (whether it's a new application or an existing listing), remove, add, or reject the applicant/listing
Is there some name that covers both aspects? Otherwise, it might make sense to split updateStatus() into two separate functions. Something like finalizeApplication() and finalizeChallenge()?
The text was updated successfully, but these errors were encountered:
I find it unclear from the name what
updateStatus()
is supposed to do, which makes it difficult to remember when it is necessary to call it.From the code, it looks like it can either
Is there some name that covers both aspects? Otherwise, it might make sense to split
updateStatus()
into two separate functions. Something likefinalizeApplication()
andfinalizeChallenge()
?The text was updated successfully, but these errors were encountered: