Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with latest Magisk #73

Open
hexdefined opened this issue Sep 2, 2024 · 9 comments
Open

Not compatible with latest Magisk #73

hexdefined opened this issue Sep 2, 2024 · 9 comments

Comments

@hexdefined
Copy link

Magisk removed the NVBASE variable in topjohnwu/Magisk@d33b077, causing get_modpath.sh in the app to fail, because it uses util_functions.sh and assumes NVBASE has been set.

get_modpath.sh[40]: [: 30: unexpected operator/operand
/modules_update/quickswitch
/modules/quickswitch
@osm0sis
Copy link
Contributor

osm0sis commented Sep 19, 2024

Can confirm this is the cause of most of the recent "Oops" error related regressions/issues. @skittles9823 @paphonb

Until the QuickSwitch app gets fixed users can add the following line to the bottom of /data/adb/magisk/util_functions.sh and it should get things working:

NVBASE=/data/adb

@FERFAIL-TXZ
Copy link

Can confirm this is the cause of most of the recent "Oops" error related regressions/issues. @skittles9823 @paphonb

Until the QuickSwitch app gets fixed users can add the following line to the bottom of /data/adb/magisk/util_functions.sh and it should get things working:

NVBASE=/data/adb

This worked for me, thanks!

@Tr0ji
Copy link

Tr0ji commented Dec 17, 2024

OMG I haven't been able to use QuickSwitch for months now. Thanks heaps

@osm0sis
Copy link
Contributor

osm0sis commented Dec 17, 2024

OMG I haven't been able to use QuickSwitch for months now. Thanks heaps

Yeah, not sure if everyone's just busy or what, but hopefully they recompile the APK with the fix included sometime soon...

CC: @skittles9823 @paphonb

@FabianMPunkt
Copy link

Until the QuickSwitch app gets fixed users can add the following line to the bottom of /data/adb/magisk/util_functions.sh and it should get things working:

NVBASE=/data/adb

Hey, please excuse my ignorance but where exactly is this file? 😅 I am not able to find it anywhere on LineageOS22.1. Do i need to build Magisk from source or something?

@osm0sis
Copy link
Contributor

osm0sis commented Jan 12, 2025

Magisk needs to be installed, and then it's exactly where I said.

@FabianMPunkt
Copy link

Sorry i had to use a different file manager that actually shows all root folders haha. I can change the recents provider now, but Lawnchair always crashes whenever i open the recents menu (Lawnchair 15.Dev #1922)

@Ajaymamtora
Copy link

Magisk needs to be installed, and then it's exactly where I said.

Is there an alternative for KSU?

@LittleLogie
Copy link

Can confirm this is the cause of most of the recent "Oops" error related regressions/issues. @skittles9823 @paphonb

Until the QuickSwitch app gets fixed users can add the following line to the bottom of /data/adb/magisk/util_functions.sh and it should get things working:

NVBASE=/data/adb

I thought the issue was my rom, thanks it worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants