Not working in PHP8.3.8

[maxakropolis]

Tests fail with the following when using PHP8.3.8

BadMethodCallException: Call to undefined method Sinnbeck\DomAssertions\Asserts\AssertForm::getParser()

Adding

    protected function getParser(): DomParser
    {
        return $this->parser;
    }

to BaseAssert made it work, although what this indicates I don't know - perhaps that the magic __call method is being called rather than the methods in the traits?

[sinnbeck]

Hm interesting. I will try getting that set up so I can recreate the issue myself.

Edit: I upgraded to latest php version which seems to be 8.3.7? https://www.php.net/downloads.php#v8.3.7

[maxakropolis]

Yeah - I assume the git action we use (shivammathur/setup-php@v2) is accidentally pulling in 8.3.8 RC1 (I've tested it locally with 8.3.8 RC1) to prove this.

So this is possibly an issue that will resolve itself but it might be something that needs addressing 🤷

[sinnbeck]

Sounds like it. But yeah it's weird that it uses RC instead of stable :) I will conciser installing the RC using docker to try and replicate it.

[sinnbeck]

I think this might be related: php/php-src#14480

[maxakropolis]

Thanks @sinnbeck - I hoped it was a bug rather than intended behaviour. Hopefully that means we can all just sit on our hands and the problem will correct itself. We've forked a patched version for now to keep our CI working.

[sinnbeck]

So it seems they released it with the bug :/ I will start writing a fix for the package. Setting the method to public should fix it.

[sinnbeck]

Patch is live. https://github.com/sinnbeck/laravel-dom-assertions/releases/tag/v1.5.1

If this works for you I will close this issue :)

[maxakropolis]

Yep - looking good here. Thank you very much 🎉

[sinnbeck]

Excellent to hear! Sorry I couldnt get a fix out sooner but I assumed that the bug would be fixed before release :) I will look into whether I should roll back the change in 8.3.9, but most like I wont