It should be possible to remove event listeners

[Rychu-Pawel]

What problem are you trying to solve? Describe the feature.

Currently, there is no way to remove event listeners, e.g., for uploadProgress event.

const ongoingRequestPromise = gotChunkInstance.post(uploadUrl, {
    body: await chunkStreamProvider.getChunkStream() //this is an FS ReadStream
});

const eventListener = (progress: Progress) => {
    console.log(progress);
};

ongoingRequestPromise.on("uploadProgress", eventListener);

setTimeout(() => {
    // This is not possible
    ongoingRequestPromise.removeEventListener("uploadProgress", eventListener);
}, 2000);

Checklist

• I have read the documentation and made sure this feature doesn't already exist.

[sindresorhus]

You can just add a conditional in your listener to stop handling it.

[Rychu-Pawel]

Do you mean something like this?

const ongoingRequestPromise = gotChunkInstance.post(uploadUrl, {
    body: await chunkStreamProvider.getChunkStream() //this is an FS ReadStream
});

let stopListening = false;

const eventListener = (progress: Progress) => {
    if (stopListening)
        return;

    console.log(progress);
};

ongoingRequestPromise.on("uploadProgress", eventListener);

setTimeout(() => {
   stopListening = true;
}, 2000);

Yes, I can but that doesn't look perfect... I would rather prefer to just unregister the listener :)

[sindresorhus]

Fixed by #2092