Wrong applying encodeURIComponent to credentials for Basic Auth

[izonder]

Describe the bug

• Node.js version: 12.13.0
• OS & version: Ubuntu 18.04 Linux 4.15.0-72-generic Reselect agent on redirect from http to https #81-Ubuntu SMP Tue Nov 26 12:20:02 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Passing credentials in options.username and options.password that contain "unsafe" characters leads to applying encodeURIComponent to them with wrong Base64-encoded string as a result.

Actual behavior

Making a call with {"username": "test@test", "password": "123456"} results to having the following authorization header:

Authorization: Basic dGVzdCU0MHRlc3Q6MTIzNDU2

After decoding we get the string: test%40test:123456

Expected behavior

Reference call via cURL will result differently:

curl -u 'test@test:123456' -v 'http://localhost:3000/'
*   Trying 127.0.0.1...
* TCP_NODELAY set
* Connected to localhost (127.0.0.1) port 3000 (#0)
* Server auth using Basic with user 'test@test'
> GET / HTTP/1.1
> Host: localhost:3000
> Authorization: Basic dGVzdEB0ZXN0OjEyMzQ1Ng==
> User-Agent: curl/7.58.0
> Accept: */*

curl -v 'http://test%40test:123456@localhost:3000/'
*   Trying 127.0.0.1...
* TCP_NODELAY set
* Connected to localhost (127.0.0.1) port 3000 (#0)
* Server auth using Basic with user 'test@test'
> GET / HTTP/1.1
> Host: localhost:3000
> Authorization: Basic dGVzdEB0ZXN0OjEyMzQ1Ng==
> User-Agent: curl/7.58.0
> Accept: */*

Decoding the Authorization header results to test@test:123456 as expected.

Code to reproduce

got.get('http://localhost:3000/', {
    username: 'test@test',
    password: '123456'
})
  .then((r) => console.log(r))
  .catch((e) => console.log(e));

Checklist

• I have read the documentation.
• I have tried my code with the latest version of Node.js and Got.

[izonder]

The issue caused by URL object behavior: https://nodejs.org/dist/latest-v12.x/docs/api/url.html#url_url_username

[izonder]

Just as a comment: very easily reproducing. Launch Node.js CLI (node -i), and then type:

const {URL} = require('url');
const http = require('http');
const url = new URL('http://localhost'); //doesn't matter whether there is listening server here or not
url.username = 'test@test';
url.password = '123456';
console.log(http.get(url, () => {}).outputData);

You will see the output:

[
  {
    data: 'GET /profile HTTP/1.1\r\n' +
      'Host: localhost\r\n' +
      'Authorization: Basic dGVzdCU0MHRlc3Q6MTIzNDU2\r\n' +
      'Connection: close\r\n' +
      '\r\n',
    encoding: 'latin1',
    callback: [Function: bound onFinish]
  }
]

Decoding Authorization header results to test%40test:123456

[izonder]

nodejs/node#31439